Ticket #42251: 42251-tests.diff

tests/phpunit/tests/multisite/network.php

@@ -592 +592 @@
 
                 $this->assertSame( (string) self::$different_site_ids[0], $network->blog_id );
         }
+
+        /**
+         * @ticket 42251
+         */
+        public function test_wp_site_get_instance_doesnt_exist() {
+                $this->assertFalse(WP_Network::get_instance( $this->_get_next_network_id()));
+        }
+
+        /**
+         * @ticket 42251
+         */
+        public function test_wp_site_get_instance_doesnt_exist_but_later_exists() {
+                $new_site_id = $this->_get_next_network_id();
+                $this->assertFalse(WP_Network::get_instance($new_site_id));
+                $new_network = $this->factory()->network->create_and_get();
+                //make sure we were right about what the new network's ID would be
+                $this->assertEquals($new_site_id, $new_network->id);
+                //verify that if we fetch the network now, it's no longer false
+                $fetched_network = WP_Network::get_instance($new_site_id);
+                $this->assertInstanceOf('WP_Network', $fetched_network);
+                $this->assertEquals($new_site_id, $fetched_network->id);
+        }
+
+        /**
+         * Gets the ID of the site with the highest ID
+         * @return int
+         */
+        protected function _get_next_network_id() {
+                global $wpdb;
+                //create an extra network, just to make sure we know the ID of the following one
+                static::factory()->network->create();
+                return (int)$wpdb->get_var('SELECT id FROM ' . $wpdb->site . ' ORDER BY id DESC LIMIT 1') + 1;
+        }
 }
 
 endif;

tests/phpunit/tests/multisite/site.php

@@ -1242 +1242 @@
                         array( 'current_blog_%domain%%path%', 'site-options' ),
                 );
         }
+
+        /**
+         * @ticket 42251
+         */
+        public function test_wp_site_get_instance_doesnt_exist() {
+                $this->assertFalse(WP_Site::get_instance( $this->_get_next_site_id()));
+        }
+
+        /**
+         * @ticket 42251
+         */
+        public function test_wp_site_get_instance_doesnt_exist_but_later_exists() {
+                $new_site_id = $this->_get_next_site_id();
+                $this->assertFalse(WP_Site::get_instance($new_site_id));
+                $new_site = $this->factory()->blog->create_and_get();
+                //double check we got the ID of the new site correct
+                $this->assertEquals($new_site_id, $new_site->blog_id);
+                //verify that if we fetch the site now, it's no longer false
+                $fetched_site = WP_Site::get_instance($new_site_id);
+                $this->assertInstanceOf('WP_Site', $fetched_site);
+                $this->assertEquals($new_site_id, $fetched_site->blog_id);
+
+        }
+
+        /**
+         * Gets the ID of the next site that will get inserted
+         * @return int
+         */
+        protected function _get_next_site_id() {
+                global $wpdb;
+                //create an entry
+                static::factory()->blog->create();
+                //get the ID after it
+                return (int)$wpdb->get_var('SELECT blog_id FROM ' . $wpdb->blogs . ' ORDER BY blog_ID DESC LIMIT 1') + 1;
+        }
 }
 
 endif;