Ticket #42469: 42469.2.diff

src/wp-includes/class-wp-query.php

@@ -3030 +3030 @@
                          * @param string   $found_posts The query to run to find the found posts.
                          * @param WP_Query $this        The WP_Query instance (passed by reference).
                          */
-                        $this->found_posts = $wpdb->get_var( apply_filters_ref_array( 'found_posts_query', array( 'SELECT FOUND_ROWS()', &$this ) ) );
+                        $found_posts_query = apply_filters_ref_array( 'found_posts_query', array( 'SELECT FOUND_ROWS()', &$this ) );
+
+                        $this->found_posts = (int) $wpdb->get_var( $found_posts_query );
                 } else {
                         $this->found_posts = count( $this->posts );
                 }

tests/phpunit/tests/post/query.php

@@ -535 +535 @@
                 $this->assertEquals( 2, $q->found_posts );
                 $this->assertEquals( 2, $q->max_num_pages );
         }
+
+        /**
+         * The found_posts property should be of type int, not string.
+         *
+         * @ticket 42469
+         */
+        public function test_found_posts_should_be_integer_not_string() {
+                $this->post_id = self::factory()->post->create();
+
+                $q = new WP_Query( array(
+                        'posts_per_page' => 1,
+                ) );
+
+                $this->assertTrue( is_int( $q->found_posts ) );
+                $this->assertFalse( is_string( $q->found_posts ) );
+        }
 }