Ticket #42469: 42469.3.diff

src/wp-includes/class-wp-query.php

@@ -3030 +3030 @@
                          * @param string   $found_posts The query to run to find the found posts.
                          * @param WP_Query $this        The WP_Query instance (passed by reference).
                          */
-                        $this->found_posts = $wpdb->get_var( apply_filters_ref_array( 'found_posts_query', array( 'SELECT FOUND_ROWS()', &$this ) ) );
+                        $found_posts_query = apply_filters_ref_array( 'found_posts_query', array( 'SELECT FOUND_ROWS()', &$this ) );
+
+                        $this->found_posts = (int) $wpdb->get_var( $found_posts_query );
                 } else {
                         $this->found_posts = count( $this->posts );
                 }
@@ -3043 +3045 @@
                  * @param int      $found_posts The number of posts found.
                  * @param WP_Query $this        The WP_Query instance (passed by reference).
                  */
-                $this->found_posts = apply_filters_ref_array( 'found_posts', array( $this->found_posts, &$this ) );
+                $this->found_posts = (int) apply_filters_ref_array( 'found_posts', array( $this->found_posts, &$this ) );
 
                 if ( ! empty( $limits ) )
                         $this->max_num_pages = ceil( $this->found_posts / $q['posts_per_page'] );

tests/phpunit/tests/post/query.php

@@ -535 +535 @@
                 $this->assertEquals( 2, $q->found_posts );
                 $this->assertEquals( 2, $q->max_num_pages );
         }
+
+        /**
+         * The found_posts property should be of type int, not string.
+         *
+         * @ticket 42469
+         */
+        public function test_found_posts_should_be_integer_not_string() {
+                $this->post_id = self::factory()->post->create();
+
+                $q = new WP_Query( array(
+                        'posts_per_page' => 1,
+                ) );
+
+                $this->assertTrue( is_int( $q->found_posts ) );
+                $this->assertFalse( is_string( $q->found_posts ) );
+        }
+
+        /**
+         * The found_posts property should be of type int, even if the found_posts filter returns a string value.
+         *
+         * @ticket 42469
+         */
+        public function test_found_posts_should_be_integer_even_if_found_posts_filter_returns_string_value() {
+                $this->post_id = self::factory()->post->create();
+
+                add_filter( 'found_posts', array( $this, 'filter_found_posts_string' ) );
+
+                $q = new WP_Query( array(
+                        'posts_per_page' => 1,
+                ) );
+
+                remove_filter( 'found_posts', array( $this, 'filter_found_posts_string' ) );
+
+                $this->assertTrue( is_int( $q->found_posts ) );
+                $this->assertFalse( is_string( $q->found_posts ) );
+        }
+
+        /**
+         * Filter callback - string casting.
+         *
+         * @param  int $found_posts Found posts.
+         * @return string $found_posts Found posts as string value.
+         */
+        public function filter_found_posts_string( $found_posts ) {
+                return (string) $found_posts;
+        }
 }