Ticket #42742: 42742_wp_error_has_errors_method.diff

src/wp-includes/class-wp-error.php

@@ -31 +31 @@
          *
          * @since 2.1.0
          * @var array
-         */
+         */
         public $error_data = array();
 
         /**
@@ -71 +71 @@
          * @return array List of error codes, if available.
          */
         public function get_error_codes() {
-                if ( empty( $this->errors ) ) {
+                if ( ! $this->has_errors() ) {
                         return array();
                 }
 
@@ -161 +161 @@
                 }
         }
 
+        /**
+         * Verify if instance contains errors.
+         *
+         * @since 5.0.0
+         *
+         * @return bool
+         */
+        public function has_errors() {
+                if ( ! empty( $this->errors ) ) {
+                        return true;
+                }
+                return false;
+        }
+
         /**
          * Add an error or append additional message to an existing error.
          *

tests/phpunit/tests/general/wpError.php

@@ -415 +415 @@
                 $this->assertSame( 'data2', $this->WP_Error->get_error_data( 'code' ) );
         }
 
+        /**
+         * @covers WP_Error::has_errors()
+         */
+        public function test_has_errors_with_no_errors_returns_false() {
+                $this->assertFalse( $this->WP_Error->has_errors() );
+        }
+
+        /**
+         * @covers WP_Error::has_errors()
+         */
+        public function test_has_errors_with_errors_returns_true() {
+                $this->WP_Error->add( 'code', 'message', 'data' );
+                $this->assertTrue( $this->WP_Error->has_errors() );
+        }
+
         /**
          * @covers WP_Error::add()
          */