Ticket #42904: 42904-2.patch

phpunit.xml.dist

@@ -23 +23 @@
     <groups>
         <exclude>
             <group>ajax</group>
+            <group>factory</group>
             <group>ms-files</group>
             <group>ms-required</group>
             <group>external-http</group>

tests/phpunit/includes/bootstrap.php

@@ -105 +105 @@
 // Delete any default posts & related data
 _delete_all_posts();
 
+require dirname( __FILE__ ) . '/class-mock-passwordhash.php';
 require dirname( __FILE__ ) . '/testcase.php';
 require dirname( __FILE__ ) . '/testcase-rest-api.php';
 require dirname( __FILE__ ) . '/testcase-rest-controller.php';

new file tests/phpunit/includes/class-mock-passwordhash.php

@@ +1 @@
+<?php
+/**
+* Mock of the phpass class.
+*
+* @since 5.0.0
+*/
+
+/**
+* Class Mock_PasswordHash
+*/
+class Mock_PasswordHash {
+        // phpcs:disable WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid --- the mocked class does not use snake case.
+        function HashPassword( $password ) {
+                return $password;
+        }
+}

tests/phpunit/includes/factory/class-wp-unittest-factory-for-user.php

@@ -22 +22 @@
         }
 
         function create_object( $args ) {
+                // Do not hash the user's password, use the mock hasher instead that returns the password in plain text.
+                if ( isset( $args['skip_password_hash'] ) && true === $args['skip_password_hash'] ) {
+                        // phpcs:disable WordPress.Variables.GlobalVariables.OverrideProhibited --- overriding on purpose.
+                        $GLOBALS['wp_hasher'] = new Mock_PasswordHash();
+
+                        $user = wp_insert_user( $args );
+
+                        // Unset the hasher global to ensure that the next call to `wp_hash_password()` creates a new instance, and
+                        // everything works correctly.
+                        unset( $GLOBALS['wp_hasher'] );
+
+                        return $user;
+                }
+
                 return wp_insert_user( $args );
         }
 

tests/phpunit/multisite.xml

@@ -24 +24 @@
     <groups>
         <exclude>
             <group>ajax</group>
+            <group>factory</group>
             <group>ms-files</group>
             <group>ms-excluded</group>
             <group>external-http</group>

new file tests/phpunit/tests/factory/test-user.php

@@ +1 @@
+<?php
+/**
+ * Tests for the user fixture factory.
+ *
+ * @group factory
+ */
+class Tests_WP_UnitTest_Factory_For_User extends WP_UnitTestCase {
+        /**
+         * Test that password hashing can be skipped when creating a user fixture, to improve performance.
+         */
+        public function test_skip_password_hash() {
+                global $wpdb;
+
+                $user_id = self::factory()->user->create( array(
+                        'skip_password_hash' => true,
+                ) );
+
+                // Ensure that the password is stored as plain text.
+                $stored_password = $wpdb->get_var( $wpdb->prepare( "SELECT 'password' FROM $wpdb->users WHERE ID = %d", $user_id ) );
+                $this->assertSame( 'password', $stored_password );
+                // Ensure that the global variable containing the password hasher does not exist. This will ensure that
+                // `wp_hash_password()` creates a new instance, and everything works correctly.
+                $this->assertFalse( isset( $GLOBALS['wp_hasher'] ) );
+        }
+}