Ticket #42904: 42904.patch

tests/phpunit/includes/bootstrap.php

@@ -115 +115 @@
 require dirname( __FILE__ ) . '/exceptions.php';
 require dirname( __FILE__ ) . '/utils.php';
 require dirname( __FILE__ ) . '/spy-rest-server.php';
+require dirname( __FILE__ ) . '/class-mock-passwordhash.php';
+
+/**
+ * Override the $wp_hasher global that contains an instance of the PasswordHash class.
+ *
+ * By mocking the hashing functions used for password handling, we can speed up user creation in unit tests.
+ *
+ * @since 5.0.0
+ */
+$GLOBALS['wp_hasher'] = new Mock_PasswordHash();
 
 /**
  * A child class of the PHP test runner.

new file tests/phpunit/includes/class-mock-passwordhash.php

@@ +1 @@
+<?php
+/**
+ * Mock of the phpass class.
+ *
+ * @since 5.0.0
+ */
+
+/**
+ * Class Mock_PasswordHash
+ */
+class Mock_PasswordHash {
+        function HashPassword( $password ) {
+                // The password needs to be longer than 32 characters, so that `wp_check_password()` uses the hasher class.
+                return 'bar_bar_bar_bar_bar_bar_bar_bar_bar_';
+        }
+
+        function CheckPassword( $password, $stored_hash ) {
+                return true;
+        }
+}

tests/phpunit/tests/auth.php

@@ -16 +16 @@
         protected $nonce_failure_hook = 'wp_verify_nonce_failed';
 
         public static function wpSetUpBeforeClass( $factory ) {
+                /**
+                 * Set the $wp_hasher global to null. This causes the password related functions in Core to create a valid
+                 * instance of the PasswordHash class.
+                 */
+                $GLOBALS['wp_hasher'] = null;
+
                 self::$_user = $factory->user->create_and_get(
                         array(
                                 'user_login' => 'password-tests',
@@ -28 +34 @@
                 self::$wp_hasher = new PasswordHash( 8, true );
         }
 
+        public static function wpTearDownAfterClass() {
+                // Set the $wp_hasher global to the test mock.
+                $GLOBALS['wp_hasher'] = new Mock_PasswordHash();
+        }
+
         function setUp() {
                 parent::setUp();
 

tests/phpunit/tests/xmlrpc/basic.php

@@ -37 +37 @@
          * @ticket 34336
          */
         function test_multicall_invalidates_all_calls_after_invalid_call() {
+                /**
+                 * Set the $wp_hasher global to null. This causes the password related functions in Core to create a valid
+                 * instance of the PasswordHash class.
+                 */
+                $GLOBALS['wp_hasher'] = null;
+
                 $editor_id = $this->make_user_by_role( 'editor' );
                 $post_id   = self::factory()->post->create(
                         array(
@@ -94 +100 @@
                 $this->assertArrayHasKey( 'faultCode', $result[1] );
                 $this->assertArrayHasKey( 'faultCode', $result[2] );
 
+                // Set the $wp_hasher global to the test mock.
+                $GLOBALS['wp_hasher'] = new Mock_PasswordHash();
         }
 
         /**

tests/phpunit/tests/xmlrpc/wp/editProfile.php

@@ -40 +40 @@
         }
 
         function test_ignore_password_change() {
+                /**
+                 * Set the $wp_hasher global to null. This causes the password related functions in Core to create a valid
+                 * instance of the PasswordHash class.
+                 */
+                $GLOBALS['wp_hasher'] = null;
+
                 $this->make_user_by_role( 'author' );
                 $new_pass = 'newpassword';
                 $new_data = array( 'password' => $new_pass );
@@ -52 +58 @@
                 $auth_new = wp_authenticate( 'author', $new_pass );
                 $this->assertInstanceOf( 'WP_User', $auth_old );
                 $this->assertWPError( $auth_new );
+
+                // Set the $wp_hasher global to the test mock.
+                $GLOBALS['wp_hasher'] = new Mock_PasswordHash();
         }
 
         function test_ignore_email_change() {