Ticket #43160: a43160.diff

wp-includes/option.php

@@ -1766 +1766 @@
 }
 
 /**
+ * Set/update the value of a site transient without calling the sometimes expensive hooks.
+ *
+ * This is particularly for the special case of wp_update_plugins() where set_site_transient() was called twice
+ * and the first time was only for setting up the last_checked update_plugins option.
+ *
+ * @since 4.9.3
+ *
+ * @see wp_update_plugins()
+ *
+ * @param string $transient  Transient name. Expected to not be SQL-escaped. Must be
+ *                           167 characters or fewer in length.
+ * @param mixed  $value      Transient value. Expected to not be SQL-escaped.
+ * @param int    $expiration Optional. Time until expiration in seconds. Default 0 (no expiration).
+ * @return bool False if value was not set and true if value was set.
+*/
+function set_site_transient_nohook( $transient, $value, $expiration = 0 ) {
+
+        $expiration = (int) $expiration;
+
+        if ( wp_using_ext_object_cache() ) {
+                $result = wp_cache_set( $transient, $value, 'site-transient', $expiration );
+        } else {
+                $transient_timeout = '_site_transient_timeout_' . $transient;
+                $option = '_site_transient_' . $transient;
+                if ( false === get_site_option( $option ) ) {
+                        if ( $expiration )
+                                add_site_option( $transient_timeout, time() + $expiration );
+                        $result = add_site_option( $option, $value );
+                } else {
+                        if ( $expiration )
+                                update_site_option( $transient_timeout, time() + $expiration );
+                        $result = update_site_option( $option, $value );
+                }
+        }
+        return $result;
+}
+
+/**
  * Set/update the value of a site transient.
  *
  * You do not need to serialize values, if the value needs to be serialize, then
@@ -1811 +1849 @@
          */
         $expiration = apply_filters( "expiration_of_site_transient_{$transient}", $expiration, $value, $transient );
 
-        if ( wp_using_ext_object_cache() ) {
-                $result = wp_cache_set( $transient, $value, 'site-transient', $expiration );
-        } else {
-                $transient_timeout = '_site_transient_timeout_' . $transient;
-                $option            = '_site_transient_' . $transient;
-                if ( false === get_site_option( $option ) ) {
-                        if ( $expiration ) {
-                                add_site_option( $transient_timeout, time() + $expiration );
-                        }
-                        $result = add_site_option( $option, $value );
-                } else {
-                        if ( $expiration ) {
-                                update_site_option( $transient_timeout, time() + $expiration );
-                        }
-                        $result = update_site_option( $option, $value );
-                }
-        }
+        $result = set_site_transient_nohook( $transient, $value, $expiration );
+
         if ( $result ) {
 
                 /**

wp-includes/update.php

@@ -67 +67 @@
 
         // Update last_checked for current to prevent multiple blocking requests if request hangs
         $current->last_checked = time();
-        set_site_transient( 'update_core', $current );
+        set_site_transient_nohook( 'update_plugins', $current );
 
         if ( method_exists( $wpdb, 'db_version' ) ) {
                 $mysql_version = preg_replace( '/[^0-9.].*/', '', $wpdb->db_version() );