Ticket #43632: 43632.7.diff

src/wp-content/plugins/hello.php

@@ -10 +10 @@
 Author: Matt Mullenweg
 Version: 1.7.1
 Author URI: http://ma.tt/
+Text Domain: hello-dolly
 */
 
 function hello_dolly_get_lyric() {
@@ -52 +53 @@
 // This just echoes the chosen line, we'll position it later
 function hello_dolly() {
         $chosen = hello_dolly_get_lyric();
-        echo "<p id='dolly'>$chosen</p>";
+        $lang = '';
+        if ( 'en_' !== substr( get_user_locale(), 0, 3 ) ) {
+                $lang = " lang='en'";
+        }
+        
+        printf(
+                '<p id="dolly"%s><span class="screen-reader-text">%s </span><span>%s</span></p>',
+                $lang,
+                __( 'Quote from Hello Dolly song, by Jerry Herman:', 'hello-dolly' ),
+                $chosen
+        );
 }
 
 // Now we set that function up to execute when the admin_notices action is called
@@ -60 +71 @@
 
 // We need some CSS to position the paragraph
 function dolly_css() {
-        // This makes sure that the positioning is also good for right-to-left languages
-        $x = is_rtl() ? 'left' : 'right';
-
         echo "
         <style type='text/css'>
         #dolly {
-                float: $x;
-                padding-$x: 15px;
-                padding-top: 5px;               
+                float: right;
+                padding: 6px 10px 4px 0;
                 margin: 0;
+                line-height: 1.7;
                 font-size: 11px;
         }
+        body.rtl #dolly {
+                float: left;
+                padding: 6px 0 4px 10px;
+        }
         .block-editor-page #dolly {
                 display: none;
         }
+        @media screen and (max-width: 782px) {
+                #dolly {
+                        float: none;
+                }
+        }
         </style>
         ";
 }