Ticket #43636: clean_up_unit_test.diff

src/wp-includes/class-wp-query.php

@@ -1855 +1855 @@
                         case 'id=>parent':
                                 $fields = "{$wpdb->posts}.ID, {$wpdb->posts}.post_parent";
                                 break;
+                        case 'id=>author_id': 
+                                $fields = "{$wpdb->posts}.ID, {$wpdb->posts}.post_author"; 
+                                break; 
+                        case 'id=>title': 
+                                $fields = "{$wpdb->posts}.ID, {$wpdb->posts}.post_title"; 
+                                break; 
                         default:
                                 $fields = "{$wpdb->posts}.*";
                 }
@@ -2907 +2913 @@
                         return $r;
                 }
 
+                if ( 'id=>author_id' == $q['fields'] ) {
+                        if ( null === $this->posts ) {
+                                $this->posts = $wpdb->get_results( $this->request );
+                        }
+
+                        $this->post_count = count( $this->posts );
+                        $this->set_found_posts( $q, $limits );
+
+                        $r = array();
+                        foreach ( $this->posts as $key => $post ) {
+                                $this->posts[ $key ]->ID = (int) $post->ID;
+                                $this->posts[ $key ]->post_author = (int) $post->post_author;
+
+                                $r[ (int) $post->ID ] = (int) $post->post_author;
+                        }
+
+                        return $r;
+                }
+
+                if ( 'id=>title' == $q['fields'] ) {
+                        if ( null === $this->posts ) {
+                                $this->posts = $wpdb->get_results( $this->request );
+                        }
+
+                        $this->post_count = count( $this->posts );
+                        $this->set_found_posts( $q, $limits );
+
+                        $r = array();
+                        foreach ( $this->posts as $key => $post ) {
+                                $this->posts[ $key ]->ID = (int) $post->ID;
+                                $this->posts[ $key ]->post_title = sanitize_text_field( $post->post_title );
+
+                                $r[ (int) $post->ID ] = sanitize_text_field( $post->post_title );
+                        }
+
+                        return $r;
+                }
+
                 if ( null === $this->posts ) {
                         $split_the_query = ( $old_request == $this->request && "{$wpdb->posts}.*" == $fields && ! empty( $limits ) && $q['posts_per_page'] < 500 );
 

tests/phpunit/tests/query.php

@@ -685 +685 @@
                 $this->assertSame( 'tax1', get_query_var( 'taxonomy' ) );
                 $this->assertSame( 'term1', get_query_var( 'term' ) );
         }
+
+        /**
+         * @ticket 43636
+         */
+        public function test_fields_author_ids_contains_only_post_ids_and_author_ids() {
+                $user_id = $this->factory->user->create( array( 'role' => 'editor' ) );
+                $post_id = $this->factory->post->create( array( 'post_author' => $user_id ) );
+
+                $q = get_posts( array( 'fields' => 'id=>author_id' ) );
+
+                $this->assertEquals( $q[ $post_id ], $user_id );
+        }
+
+        /**
+         * @ticket 43636
+         */
+        public function test_fields_titles_contains_only_post_ids_and_titles() {
+                $post_title     = 'Test fields titles contains only post ids and titles';
+                $post_id        = $this->factory->post->create( array( 'post_title' => $post_title ) );
+
+                $q = get_posts( array( 'fields' => 'id=>title' ) );
+
+                $this->assertEquals( $q[ $post_id ], $post_title );
+        }
+
 }