Ticket #43842: 43842.diff

src/wp-includes/post.php

@@ -526 +526 @@
 function get_children( $args = '', $output = OBJECT ) {
         $kids = array();
         if ( empty( $args ) ) {
-                if ( isset( $GLOBALS['post'] ) ) {
-                        $args = array( 'post_parent' => (int) $GLOBALS['post']->post_parent );
-                } else {
+                if ( ! isset( $GLOBALS['post'] ) ) {
                         return $kids;
                 }
+                $args['post_parent'] = (int) $GLOBALS['post']->post_parent;
         } elseif ( is_object( $args ) ) {
-                $args = array( 'post_parent' => (int) $args->post_parent );
+                $args['post_parent'] = (int) $args->post_parent;
         } elseif ( is_numeric( $args ) ) {
-                $args = array( 'post_parent' => (int) $args );
+                $args['post_parent'] = (int) $args;
         }
 
         $defaults = array(
@@ -562 +561 @@
                 $kids[ $child->ID ] = $children[ $key ];
         }
 
-        if ( $output == OBJECT ) {
-                return $kids;
-        } elseif ( $output == ARRAY_A ) {
-                $weeuns = array();
-                foreach ( (array) $kids as $kid ) {
-                        $weeuns[ $kid->ID ] = get_object_vars( $kids[ $kid->ID ] );
-                }
-                return $weeuns;
-        } elseif ( $output == ARRAY_N ) {
-                $babes = array();
-                foreach ( (array) $kids as $kid ) {
-                        $babes[ $kid->ID ] = array_values( get_object_vars( $kids[ $kid->ID ] ) );
-                }
-                return $babes;
-        } else {
-                return $kids;
+        switch ( $output ) {
+                case OBJECT:
+                        return $kids;
+                        break;
+                case ARRAY_A:
+                        $weeuns = array();
+                        foreach ( (array) $kids as $kid ) {
+                                $weeuns[ $kid->ID ] = get_object_vars( $kids[ $kid->ID ] );
+                        }
+                        return $weeuns;
+                        break;
+                case ARRAY_N:
+                        $babies = array();
+                        foreach ( (array) $kids as $kid ) {
+                                $babies[ $kid->ID ] = array_values( get_object_vars( $kids[ $kid->ID ] ) );
+                        }
+                        return $babies;
+                        break;
+                default:
+                        return $kids;
+                        break;
         }
 }