Ticket #44079: 44079.diff

src/wp-admin/includes/misc.php

@@ -1263 +1263 @@
         }
 }
 
+/**
+ * Require the `manage_privacy_options` capability to edit Privacy Policy page.
+ *
+ * Normally Editors can edit any page, but the Privacy Policy page is special,
+ * and only users with the `manage_privacy_options` capability can determine
+ * which page is considered the Privacy Policy page. The most common use case
+ * is likely to be one where the site administrator wants to either make decisions
+ * related to privacy themselves, or designate a specific person to do that on
+ * behalf of the organization. In light of those, most administrator will probably
+ * not expect Editors to be able to edit the page, and allowing them to could
+ * lead to edits that the admin does not desire.
+ *
+ * @since 4.9.6
+ *
+ * @param string[] $caps    Array of the user's capabilities.
+ * @param string   $cap     Capability name.
+ * @param int      $user_id The user ID.
+ * @param array    $args    Adds the context to the cap. Typically the object ID.
+ *
+ * @return array   Capabilities.
+ */
+function _restrict_privacy_policy_page_edits( $caps, $cap, $user_id, $args ) {
+        $restricted_capabilities = array( 'edit_post', 'delete_post' );
+
+        if ( ! in_array( $cap, $restricted_capabilities, true ) ) {
+                return $caps;
+        }
+
+        $privacy_policy_page_id = (int) get_option( 'wp_page_for_privacy_policy' );
+
+        if ( ! $privacy_policy_page_id || empty( $args[0] ) || $privacy_policy_page_id !== $args[0] ) {
+                return $caps;
+        }
+
+        $caps[] = 'manage_privacy_options';
+
+        return $caps;
+}
+add_filter( 'map_meta_cap', '_restrict_privacy_policy_page_edits', 1, 4 ); // Before plugins because this is default behavior.
+
 /**
  * WP_Privacy_Policy_Content class.
  * TODO: move this to a new file.
@@ -1564 +1604 @@
                         return;
                 }
 
-                if ( ! current_user_can( 'manage_privacy_options' ) ) {
-                        return;
-                }
-
                 $policy_page_id = (int) get_option( 'wp_page_for_privacy_policy' );
 
                 if ( ! $policy_page_id || $policy_page_id != $post->ID ) {