Ticket #44192: 44192.3.diff

src/wp-includes/link-template.php

@@ -4329 +4329 @@
         $privacy_policy_url = get_privacy_policy_url();
 
         if ( $privacy_policy_url ) {
-                $link = sprintf(
-                        '<a class="privacy-policy-link" href="%s">%s</a>',
-                        esc_url( $privacy_policy_url ),
-                        __( 'Privacy Policy' )
-                );
+                $policy_page_id = (int) get_option( 'wp_page_for_privacy_policy' );
+                $page_title     = get_the_title( $policy_page_id );
+
+                if ( ! empty( $page_title ) ) {
+                        $link = sprintf(
+                                '<a class="privacy-policy-link" href="%s">%s</a>',
+                                esc_url( $privacy_policy_url ),
+                                esc_html( $page_title )
+                        );
+                }
         }
 
         /**

tests/phpunit/tests/link/getThePrivacyPolicyLink.php

@@ -11 +11 @@
  * Test cases for the `get_the_privacy_policy_link()` function.
  *
  * @group link
- * @group privacy
+ * @group privacy1
  * @covers get_the_privacy_policy_link
  *
  * @since 4.9.6
@@ -71 +71 @@
 
         /**
          * The function should return a valid link if a privacy policy page has been
-         * created and set as the `wp_page_for_privacy_policy`.
+         * created and set as the `wp_page_for_privacy_policy`. The post title should
+         * be used as the link text.
          */
         public function test_get_the_privacy_policy_link_should_return_valid_link_when_privacy_page_set() {
                 update_option( 'wp_page_for_privacy_policy', self::$privacy_policy_page_id );
@@ -80 +81 @@
 
                 $this->assertStringStartsWith( '<a', $actual_link );
                 $this->assertContains( self::$privacy_policy_url, $actual_link );
-                $this->assertStringEndsWith( '</a>', $actual_link );
+                $this->assertStringEndsWith( '>' . WP_TESTS_DOMAIN . ' Privacy Policy</a>', $actual_link );
         }
 
         /**
@@ -108 +109 @@
         }
 
         /**
+         * The function should return an empty string when there is an empty page title
+         * for the privacy policy.
+         *
+         * @ticket 44192
+         */
+        public function test_function_should_return_empty_string_when_privacy_page_title_empty() {
+                $nameless_page_id = $this->factory->post->create(
+                        array(
+                                'post_type'  => 'page',
+                                'post_title' => '',
+                        )
+                );
+
+                update_option( 'wp_page_for_privacy_policy', $nameless_page_id );
+
+                $this->assertSame( '', get_the_privacy_policy_link( self::$before, self::$after ) );
+        }
+
+        /**
          * The function should return an empty string when `wp_page_for_privacy_policy` is _not_ configured.
          */
         public function test_get_the_privacy_policy_link_should_return_empty_string_when_privacy_page_not_set() {