Ticket #44466: 44466.3.diff

src/wp-admin/includes/class-wp-terms-list-table.php

@@ -470 +470 @@
                                 __( 'Delete' )
                         );
                 }
-                if ( $tax->public ) {
+                if ( is_taxonomy_viewable( $tax ) ) {
                         $actions['view'] = sprintf(
                                 '<a href="%s" aria-label="%s">%s</a>',
                                 get_term_link( $tag ),

src/wp-includes/admin-bar.php

@@ -728 +728 @@
                 } elseif ( 'term' == $current_screen->base
                         && isset( $tag ) && is_object( $tag ) && ! is_wp_error( $tag )
                         && ( $tax = get_taxonomy( $tag->taxonomy ) )
-                        && $tax->public ) {
+                        && is_taxonomy_viewable( $tax ) ) {
                         $wp_admin_bar->add_menu(
                                 array(
                                         'id'    => 'view',

src/wp-includes/taxonomy.php

@@ -4548 +4548 @@
 
         return $parent;
 }
+
+/**
+ * Determines whether a taxonomy is considered "viewable".
+ *
+ * @since 5.1.0
+ *
+ * @param string|WP_Taxonomy $taxonomy Taxonomy name or object.
+ * @return bool Whether the taxonomy should be considered viewable.
+ */
+function is_taxonomy_viewable( $taxonomy ) {
+        if ( is_scalar( $taxonomy ) ) {
+                $taxonomy = get_taxonomy( $taxonomy );
+                if ( ! $taxonomy ) {
+                        return false;
+                }
+        }
+
+        return $taxonomy->publicly_queryable;
+}

tests/phpunit/tests/taxonomy/isTaxonomyViewable.php

@@ +1 @@
+<?php
+
+/**
+ * @group taxonomy
+ */
+class Tests_Taxonomy_IsTaxonomyViewable extends WP_UnitTestCase {
+        public function setUp() {
+                parent::setUp();
+
+                register_post_type( 'wptests_pt' );
+                register_taxonomy( 'wptests_tax_viewable', 'wptests_pt', array( 'publicly_queryable' => true ) );
+                register_taxonomy( 'wptests_tax_non_viewable', 'wptests_pt', array( 'publicly_queryable' => false ) );
+        }
+
+        /**
+         * @ticket 44466
+         */
+        public function test_is_taxonomy_viewable_for_querable_taxonomy() {
+                $this->assertTrue( is_taxonomy_viewable( 'wptests_tax_viewable' ) );
+        }
+
+        /**
+         * @ticket 44466
+         */
+        public function test_is_taxonomy_viewable_for_non_querable_taxonomy() {
+                $this->assertFalse( is_taxonomy_viewable( 'wptests_tax_non_viewable' ) );
+        }
+
+        /**
+         * @ticket 44466
+         */
+        public function test_is_taxonomy_viewable_for_non_existing_taxonomy() {
+                $this->assertFalse( is_taxonomy_viewable( 'wptests_tax_non_existing' ) );
+        }
+
+        /**
+         * @ticket 44466
+         */
+        public function test_is_taxonomy_viewable_with_object_given() {
+                $taxonomy = get_taxonomy( 'wptests_tax_viewable' );
+
+                $this->assertTrue( is_taxonomy_viewable( $taxonomy ) );
+        }
+}