WordPress.org

Make WordPress Core

Ticket #4448: 4448.patch

File 4448.patch, 857 bytes (added by pishmishy, 6 years ago)

checks return value of fopen()

  • wp-admin/theme-editor.php

     
    4343        $newcontent = stripslashes($_POST['newcontent']); 
    4444        $theme = urlencode($theme); 
    4545        if (is_writeable($real_file)) { 
     46                //is_writable() not always reliable, check return value. see comments @ http://uk.php.net/is_writable 
    4647                $f = fopen($real_file, 'w+'); 
    47                 fwrite($f, $newcontent); 
    48                 fclose($f); 
    49                 $location = "theme-editor.php?file=$file&theme=$theme&a=te"; 
     48                if ($f !== FALSE) { 
     49                        fwrite($f, $newcontent); 
     50                        fclose($f); 
     51                        $location = "theme-editor.php?file=$file&theme=$theme&a=te"; 
     52                } else { 
     53                        $location = "theme-editor.php?file=$file&theme=$theme"; 
     54                } 
    5055        } else { 
    5156                $location = "theme-editor.php?file=$file&theme=$theme"; 
    5257        }