Ticket #44672: 44672.2.diff

src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php

@@ -641 +641 @@
                         return new WP_Error( 'rest_user_invalid_id', __( 'Invalid user ID.' ), array( 'status' => 404 ) );
                 }
 
-                if ( email_exists( $request['email'] ) && $request['email'] !== $user->user_email ) {
+                if ( ( $owner_id = email_exists( $request['email'] ) ) && $owner_id !== $id ) {
                         return new WP_Error( 'rest_user_invalid_email', __( 'Invalid email address.' ), array( 'status' => 400 ) );
                 }
 

tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -1493 +1493 @@
                 $this->assertEquals( 'rest_user_invalid_email', $response->as_error()->get_error_code() );
         }
 
+        /**
+         * @ticket 44672
+         */
+        public function test_update_item_existing_email_case() {
+                wp_set_current_user( self::$editor );
+
+                $user = get_userdata( self::$editor );
+
+                $updated_email_with_case_change = ucwords( $user->user_email, '@' );
+
+                $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/users/%d', self::$editor ) );
+                $request->set_param( 'email', $updated_email_with_case_change );
+                $response = rest_get_server()->dispatch( $request );
+                $data     = $response->get_data();
+
+                $this->assertEquals( 200, $response->get_status() );
+                $this->assertEquals( $updated_email_with_case_change, $data['email'] );
+        }
+
+        /**
+         * @ticket 44672
+         */
+        public function test_update_item_existing_email_case_not_own() {
+                wp_set_current_user( self::$editor );
+
+                $user       = get_userdata( self::$editor );
+                $subscriber = get_userdata( self::$subscriber );
+
+                $updated_email_with_case_change = ucwords( $subscriber->user_email, '@' );
+
+                $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/users/%d', self::$editor ) );
+                $request->set_param( 'email', $updated_email_with_case_change );
+                $response = rest_get_server()->dispatch( $request );
+                $data     = $response->get_data();
+
+                $this->assertEquals( 400, $response->get_status() );
+        }
+
         public function test_update_item_invalid_locale() {
                 $user1 = $this->factory->user->create(
                         array(