WordPress.org
Get WordPress

Make WordPress Core

Ticket #45186: 0001-Removing-notice-jumps-in-settings-pages.patch

File 0001-Removing-notice-jumps-in-settings-pages.patch, 4.4 KB (added by elpanda13@…, 4 years ago)

Patch of the commit mentioned before

  • src/wp-admin/admin-header.php 

    From 468bcce1a2a717374f0bfdfa673683870c9926d7 Mon Sep 17 00:00:00 2001
From: "Alejandro J. Sanchez P" <alejandro.s@onthegosystems.com>
Date: Sun, 5 Jun 2022 12:00:57 +0200
Subject: [PATCH] Removing notice jumps in settings pages.

---
 src/wp-admin/admin-header.php       | 4 ++--
 src/wp-admin/options-discussion.php | 1 +
 src/wp-admin/options-general.php    | 1 +
 src/wp-admin/options-media.php      | 1 +
 src/wp-admin/options-permalink.php  | 1 +
 src/wp-admin/options-reading.php    | 1 +
 src/wp-admin/options-writing.php    | 1 +
 src/wp-admin/options.php            | 1 +
 8 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/wp-admin/admin-header.php b/src/wp-admin/admin-header.php
index 3306c9125b..7ed01544d4 100644
    a b if ( is_network_admin() ) { 
    310310 */
    311311do_action( 'all_admin_notices' );
    312312
    313 if ( 'options-general.php' === $parent_file ) {
     313/* if ( 'options-general.php' === $parent_file ) {
    314314        require ABSPATH . 'wp-admin/options-head.php';
    315 }
     315*/

  • src/wp-admin/options-discussion.php 

    diff --git a/src/wp-admin/options-discussion.php b/src/wp-admin/options-discussion.php
index b83d822f2f..dde3e51245 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php'; 
    3838
    3939<div class="wrap">
    4040<h1><?php echo esc_html( $title ); ?></h1>
     41<?php require ABSPATH . 'wp-admin/options-head.php'; ?>
    4142
    4243<form method="post" action="options.php">
    4344<?php settings_fields( 'discussion' ); ?>

  • src/wp-admin/options-general.php 

    diff --git a/src/wp-admin/options-general.php b/src/wp-admin/options-general.php
index 20c83fb1d8..59bd991927 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php'; 
    5555
    5656<div class="wrap">
    5757<h1><?php echo esc_html( $title ); ?></h1>
     58<?php require ABSPATH . 'wp-admin/options-head.php'; ?>
    5859
    5960<form method="post" action="options.php" novalidate="novalidate">
    6061<?php settings_fields( 'general' ); ?>

  • src/wp-admin/options-media.php 

    diff --git a/src/wp-admin/options-media.php b/src/wp-admin/options-media.php
index 79f4389e88..6efbd59524 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php'; 
    4848
    4949<div class="wrap">
    5050<h1><?php echo esc_html( $title ); ?></h1>
     51<?php require ABSPATH . 'wp-admin/options-head.php'; ?>
    5152
    5253<form action="options.php" method="post">
    5354<?php settings_fields( 'media' ); ?>

  • src/wp-admin/options-permalink.php 

    diff --git a/src/wp-admin/options-permalink.php b/src/wp-admin/options-permalink.php
index 87191625c7..617f7ad2cc 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php'; 
    207207?>
    208208<div class="wrap">
    209209<h1><?php echo esc_html( $title ); ?></h1>
     210<?php require ABSPATH . 'wp-admin/options-head.php'; ?>
    210211
    211212<form name="form" action="options-permalink.php" method="post">
    212213<?php wp_nonce_field( 'update-permalink' ); ?>

  • src/wp-admin/options-reading.php 

    diff --git a/src/wp-admin/options-reading.php b/src/wp-admin/options-reading.php
index 2c89f14474..c6f1550080 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php'; 
    5959
    6060<div class="wrap">
    6161<h1><?php echo esc_html( $title ); ?></h1>
     62<?php require ABSPATH . 'wp-admin/options-head.php'; ?>
    6263
    6364<form method="post" action="options.php">
    6465<?php

  • src/wp-admin/options-writing.php 

    diff --git a/src/wp-admin/options-writing.php b/src/wp-admin/options-writing.php
index e33c1df4f9..ea35c12d45 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php'; 
    5959
    6060<div class="wrap">
    6161<h1><?php echo esc_html( $title ); ?></h1>
     62<?php require ABSPATH . 'wp-admin/options-head.php'; ?>
    6263
    6364<form method="post" action="options.php">
    6465<?php settings_fields( 'writing' ); ?>

  • src/wp-admin/options.php 

    diff --git a/src/wp-admin/options.php b/src/wp-admin/options.php
index d63b10eb4f..27482c3507 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php'; ?> 
    356356
    357357<div class="wrap">
    358358        <h1><?php esc_html_e( 'All Settings' ); ?></h1>
     359        <?php require ABSPATH . 'wp-admin/options-head.php'; ?>
    359360
    360361        <div class="notice notice-warning">
    361362                <p><strong><?php _e( 'Warning:' ); ?></strong> <?php _e( 'This page allows direct access to your site settings. You can break things here. Please be cautious!' ); ?></p>