Ticket #45361: 45361.5.diff

src/wp-includes/nav-menu.php

@@ -92 +92 @@
 
         add_theme_support( 'menus' );
 
+        foreach ( $locations as $key => $value ) {
+                if ( is_int( $key ) ) {
+                        $message = __( 'Strings should always be used for menu location slugs.' );
+                        _doing_it_wrong( __FUNCTION__, $message, '5.3' );
+                        break;
+                }
+        }
+
         $_wp_registered_nav_menus = array_merge( (array) $_wp_registered_nav_menus, $locations );
 }
 

tests/phpunit/tests/menu/nav-menu.php

@@ -182 +182 @@
         /**
          * Technically possible to register menu locations numerically.
          *
+         * @expectedIncorrectUsage register_nav_menus
+         *
          * @covers ::wp_map_nav_menu_locations()
          */
         function test_numerical_locations() {
@@ -205 +207 @@
         /**
          * Technically possible old nav menu locations were registered numerically.
          *
+         * @expectedIncorrectUsage register_nav_menus
+         *
          * @covers wp_map_nav_menu_locations()
          */
         public function test_numerical_old_locations() {