WordPress.org
Get WordPress

Make WordPress Core

Ticket #46600: 46600.diff

File 46600.diff, 1.9 KB (added by sabernhardt, 4 years ago)

creating a new container class to avoid flex order, hiding that container in print styles, moving heading before the form (in the markup)

  • src/wp-content/themes/twentynineteen/comments.php 

    diff --git a/src/wp-content/themes/twentynineteen/comments.php b/src/wp-content/themes/twentynineteen/comments.php
index d00ac4611835..2e7866e3704a 100644
    a b  
    101101                // Show comment form at bottom if showing newest comments at the bottom.
    102102                if ( comments_open() && 'asc' === strtolower( get_option( 'comment_order', 'asc' ) ) ) :
    103103                        ?>
    104                         <div class="comment-form-flex">
    105                                 <span class="screen-reader-text"><?php _e( 'Leave a comment', 'twentynineteen' ); ?></span>
     104                        <div class="comment-form-wrapper">
     105                                <h2 class="comments-title"><?php _e( 'Leave a comment', 'twentynineteen' ); ?></h2>
    106106                                <?php twentynineteen_comment_form( 'asc' ); ?>
    107                                 <h2 class="comments-title" aria-hidden="true"><?php _e( 'Leave a comment', 'twentynineteen' ); ?></h2>
    108107                        </div>
    109108                        <?php
    110109                endif;

  • src/wp-content/themes/twentynineteen/print.css 

    diff --git a/src/wp-content/themes/twentynineteen/print.css b/src/wp-content/themes/twentynineteen/print.css
index ffc481cba656..98cac2826431 100644
    a b Andreas Hecht in https://www.jotform.com/blog/css-perfect-print-stylesheet-98272 
    103103  .author-description:before,
    104104  .post-navigation,
    105105  .widget-area,
     106  .comment-form-wrapper,
    106107  .comment-form-flex,
    107108  .comment-reply,
    108109  .comment .comment-metadata .edit-link {

  • src/wp-content/themes/twentynineteen/print.scss 

    diff --git a/src/wp-content/themes/twentynineteen/print.scss b/src/wp-content/themes/twentynineteen/print.scss
index 47976da65fa0..f3b49e934ed7 100644
    a b Andreas Hecht in https://www.jotform.com/blog/css-perfect-print-stylesheet-98272 
    128128        .author-description:before,
    129129        .post-navigation,
    130130        .widget-area,
     131        .comment-form-wrapper,
    131132        .comment-form-flex,
    132133        .comment-reply,
    133134        .comment .comment-metadata .edit-link {