Ticket #47048: 47048.2.diff

src/js/_enqueues/lib/nav-menu.js

@@ -1090 +1090 @@
                                         }
 
                                         e.preventDefault();
-                                } else if ( target.hasClass('select-all') ) {
-                                        selectAreaMatch = /#(.*)$/.exec(e.target.href);
-                                        if ( selectAreaMatch && selectAreaMatch[1] ) {
-                                                items = $('#' + selectAreaMatch[1] + ' .tabs-panel-active .menu-item-title input');
-                                                if( items.length === items.filter(':checked').length )
-                                                        items.removeAttr('checked');
-                                                else
-                                                        items.prop('checked', true);
-                                                return false;
+                                } else if ( target.hasClass( 'select-all' ) ) {
+                                        selectAreaMatch = target.closest( '.button-controls' ).data( 'area' );
+                                        if ( selectAreaMatch ) {
+                                                items = $( '#' + selectAreaMatch + ' .tabs-panel-active .menu-item-title input' );
+
+                                                if ( items.length === items.filter( ':checked' ).length ) {
+                                                        items.removeAttr( 'checked' );
+                                                } else {
+                                                        items.prop( 'checked', true );
+                                                }
                                         }
                                 } else if ( target.hasClass('submit-add-to-menu') ) {
                                         api.registerChange();

src/wp-admin/includes/nav-menu.php

@@ -606 +606 @@
                         <?php endif; ?>
                 </div><!-- /.tabs-panel -->
 
-                <p class="button-controls wp-clearfix">
-                        <span class="list-controls">
-                                <a href="
-                                <?php
-                                        echo esc_url(
-                                                add_query_arg(
-                                                        array(
-                                                                $post_type_name . '-tab' => 'all',
-                                                                'selectall'              => 1,
-                                                        ),
-                                                        remove_query_arg( $removed_args )
-                                                )
-                                        );
-                                ?>
-                                #posttype-<?php echo $post_type_name; ?>" class="select-all aria-button-if-js"><?php _e( 'Select All' ); ?></a>
+                <p class="button-controls wp-clearfix" data-area="posttype-<?php echo esc_attr( $post_type_name ); ?>">
+                        <span class="list-controls hide-if-no-js">
+                                <input type="checkbox" id="<?php echo esc_attr( $post_type_name . '-tab' ); ?>" class="select-all" />
+                                <label for="<?php echo esc_attr( $post_type_name . '-tab' ); ?>"><?php _e( 'Select All' ); ?></label>
                         </span>
 
                         <span class="add-to-menu">
@@ -843 +832 @@
                         </ul>
                 </div><!-- /.tabs-panel -->
 
-                <p class="button-controls wp-clearfix">
-                        <span class="list-controls">
-                                <a href="
-                                <?php
-                                        echo esc_url(
-                                                add_query_arg(
-                                                        array(
-                                                                $taxonomy_name . '-tab' => 'all',
-                                                                'selectall'             => 1,
-                                                        ),
-                                                        remove_query_arg( $removed_args )
-                                                )
-                                        );
-                                ?>
-                                #taxonomy-<?php echo $taxonomy_name; ?>" class="select-all aria-button-if-js"><?php _e( 'Select All' ); ?></a>
+                <p class="button-controls wp-clearfix" data-area="taxonomy-<?php echo esc_attr( $taxonomy_name ); ?>">
+                        <span class="list-controls hide-if-no-js">
+                                <input type="checkbox" id="<?php echo esc_attr( $taxonomy_name . '-tab' ); ?>" class="select-all" />
+                                <label for="<?php echo esc_attr( $taxonomy_name . '-tab' ); ?>"><?php _e( 'Select All' ); ?></label>
                         </span>
 
                         <span class="add-to-menu">