WordPress.org
Get WordPress

Make WordPress Core

Ticket #47138: 47138.diff

File 47138.diff, 3.5 KB (added by audrasjb, 6 years ago)

visible search label instead of placeholder in media view

  • src/js/media/views/attachments/browser.js 

    diff --git a/src/js/media/views/attachments/browser.js b/src/js/media/views/attachments/browser.js
index 0ab18afe24..ebcf2d3755 100644
    a b AttachmentsBrowser = View.extend(/** @lends wp.media.view.AttachmentsBrowser.pro 
    336336                        // Search is an input, screen reader text needs to be rendered before
    337337                        this.toolbar.set( 'searchLabel', new wp.media.view.Label({
    338338                                value: l10n.searchMediaLabel,
     339                                className: 'media-search-input-label',
    339340                                attributes: {
    340341                                        'for': 'media-search-input'
    341342                                },

  • src/js/media/views/search.js 

    diff --git a/src/js/media/views/search.js b/src/js/media/views/search.js
index f4f8f51387..a36bd521c8 100644
    a b Search = wp.media.View.extend(/** @lends wp.media.view.Search.prototype */{ 
    1818
    1919        attributes: {
    2020                type:        'search',
    21                 placeholder: l10n.searchMediaPlaceholder
    2221        },
    2322
    2423        events: {

  • src/wp-admin/css/media.css 

    diff --git a/src/wp-admin/css/media.css b/src/wp-admin/css/media.css
index 7822139c85..84d2d0776a 100644
    a b border color while dragging a file over the uploader drop area */ 
    555555        margin-top: 0;
    556556}
    557557
     558.media-search-input-label {
     559        margin: 0 .5em 0 0;
     560        vertical-align: inherit;
     561}
     562
    558563.media-frame.mode-grid .spinner {
    559564        margin-top: 16px;
    560565}

  • src/wp-admin/includes/class-wp-media-list-table.php 

    diff --git a/src/wp-admin/includes/class-wp-media-list-table.php b/src/wp-admin/includes/class-wp-media-list-table.php
index 3e5c385ac0..e00e28eb57 100644
    a b class WP_Media_List_Table extends WP_List_Table { 
    270270        </div>
    271271
    272272        <div class="search-form">
    273                 <label for="media-search-input" class="screen-reader-text"><?php esc_html_e( 'Search Media' ); ?></label>
    274                 <input type="search" placeholder="<?php esc_attr_e( 'Search media items...' ); ?>" id="media-search-input" class="search" name="s" value="<?php _admin_search_query(); ?>"></div>
     273                <label for="media-search-input" class="media-search-input-label"><?php esc_html_e( 'Search' ); ?></label>
     274                <input type="search" id="media-search-input" class="search" name="s" value="<?php _admin_search_query(); ?>"></div>
    275275        </div>
    276276                <?php
    277277        }

  • src/wp-includes/css/media-views.css 

    diff --git a/src/wp-includes/css/media-views.css b/src/wp-includes/css/media-views.css
index 243369ade0..045c096c76 100644
    a b  
    819819        max-width: 100%;
    820820}
    821821
     822.media-search-input-label {
     823        margin: 0 .5em 0 0;
     824        vertical-align: inherit;
     825}
     826
    822827/**
    823828 * Attachments
    824829 */

  • src/wp-includes/media.php 

    diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php
index d1afad5d3e..fd33fbece6 100644
    a b function wp_enqueue_media( $args = array() ) { 
    38523852                'apply'                       => __( 'Apply' ),
    38533853                'filterByDate'                => __( 'Filter by date' ),
    38543854                'filterByType'                => __( 'Filter by type' ),
    3855                 'searchMediaLabel'            => __( 'Search Media' ),
    3856                 'searchMediaPlaceholder'      => __( 'Search media items...' ), // placeholder (no ellipsis)
     3855                'searchMediaLabel'            => __( 'Search' ),
    38573856                'mediaFound'                  => __( 'Number of media items found: %d' ),
    38583857                'mediaFoundHasMoreResults'    => __( 'Number of media items displayed: %d. Scroll the page for more results.' ),
    38593858                'noMedia'                     => __( 'No media items found.' ),