Ticket #47149: 47149.2.diff

src/js/media/views/focus-manager.js

@@ +1 @@
+var $ = jQuery;
+
 /**
  * wp.media.view.FocusManager
  *
@@ -11 +13 @@
 var FocusManager = wp.media.View.extend(/** @lends wp.media.view.FocusManager.prototype */{
 
         events: {
-                'keydown': 'constrainTabbing'
+                'keydown': 'focusManagementMode'
         },
 
+        initialize: function( options ) {
+                this.mode                    = options.mode || 'constrainTabbing';
+                this.tabsAutomaticActivation = options.tabsAutomaticActivation || false;
+        },
+
+        /**
+         * Determines which focus management mode to use.
+         *
+         * @since 5.3.0
+         *
+         * @param {object} event jQuery event object.
+         *
+         * @returns {void}
+         */
+        focusManagementMode: function( event ) {
+                if ( this.mode === 'constrainTabbing' ) {
+                        this.constrainTabbing( event );
+                }
+
+                if ( this.mode === 'tabsNavigation' ) {
+                        this.tabsNavigation( event );
+                }
+        },
+
         /**
          * Gets all the tabbable elements.
          *
@@ -164 +190 @@
          *
          * @since 5.3.0
          */
-        ariaHiddenElements: []
+        ariaHiddenElements: [],
+
+        /**
+         * Holds the jQuery collection of tabs.
+         *
+         * @since 5.3.0
+         */
+        tabs: $(),
+
+        /**
+         * Initializes tabs in an ARIA tabbed interface.
+         *
+         * @since 5.3.0
+         *
+         * @param {object} event jQuery event object.
+         *
+         * @returns {void}
+         */
+        initializeAriaTabs: function() {
+                this.tabs = this.$( '[role="tab"]' );
+
+                // Set up initial attributes.
+                this.tabs.attr( {
+                        'aria-selected': false,
+                        tabIndex: '-1'
+                } );
+
+                // Set up attributes on the initially active tab.
+                this.tabs.filter( '.active' )
+                        .removeAttr( 'tabindex' )
+                        .attr( 'aria-selected', 'true' );
+        },
+
+        /**
+         * Enables arrows navigation within the ARIA tabbed interface.
+         *
+         * @since 5.3.0
+         *
+         * @param {object} event jQuery event object.
+         *
+         * @returns {void}
+         */
+        tabsNavigation: function( event ) {
+                var orientation = 'horizontal',
+                        keys = [ 32, 35, 36, 37, 38, 39, 40 ];
+
+                // Return if not Spacebar, End, Home, or Arrow keys.
+                if ( keys.indexOf( event.which ) === -1 ) {
+                        return;
+                }
+
+                // Determine navigation direction.
+                if ( this.$el.attr( 'aria-orientation' ) === 'vertical' ) {
+                        orientation = 'vertical';
+                }
+
+                // Make Up and Down arrow keys do nothing with horizontal tabs.
+                if ( orientation === 'horizontal' && [ 38, 40 ].indexOf( event.which ) !== -1 ) {
+                        return;
+                }
+
+                // Make Left and Right arrow keys do nothing with vertical tabs.
+                if ( orientation === 'vertical' && [ 37, 39 ].indexOf( event.which ) !== -1 ) {
+                        return;
+                }
+
+                this.switchTabs( event, this.tabs );
+        },
+
+        /**
+         * Switch tabs in the ARIA tabbed interface.
+         *
+         * @since 5.3.0
+         *
+         * @param {object} event jQuery event object.
+         *
+         * @returns {void}
+         */
+        switchTabs: function( event ) {
+                var key   = event.which,
+                        index = this.tabs.index( jQuery( event.target ) ),
+                        newIndex;
+
+                switch ( key ) {
+                        // Space bar: Activate current targeted tab.
+                        case 32: {
+                                this.activateTab( this.tabs[ index ] );
+                                break;
+                        }
+                        // End key: Activate last tab.
+                        case 35: {
+                                event.preventDefault();
+                                this.activateTab( this.tabs[ this.tabs.length - 1 ] );
+                                break;
+                        }
+                        // Home key: Activate first tab.
+                        case 36: {
+                                event.preventDefault();
+                                this.activateTab( this.tabs[ 0 ] );
+                                break;
+                        }
+                        // Left and up keys: Activate previous tab.
+                        case 37:
+                        case 38: {
+                                event.preventDefault();
+                                newIndex = ( index - 1 ) < 0 ? this.tabs.length - 1 : index - 1;
+                                this.activateTab( this.tabs[ newIndex ] );
+                                break;
+                        }
+                        // Right and down keys: Activate next tab.
+                        case 39:
+                        case 40: {
+                                event.preventDefault();
+                                newIndex = ( index + 1 ) === this.tabs.length ? 0 : index + 1;
+                                this.activateTab( this.tabs[ newIndex ] );
+                                break;
+                        }
+                }
+        },
+
+        /**
+         * Sets all the tabs to be not focusable and semantically not selected.
+         *
+         * @since 5.3.0
+         *
+         * @param {object} tabs The tabs jQuery collection.
+         *
+         * @returns {void}
+         */
+        deactivateTabs: function( tabs ) {
+                tabs
+                        .attr( {
+                                'aria-selected': 'false',
+                                tabIndex: '-1'
+                        } );
+        },
+
+        /**
+         * Sets a single tab to be focusable and semantically selected.
+         *
+         * @since 5.3.0
+         *
+         * @param {object} tab  The tab DOM element.
+         *
+         * @returns {void}
+         */
+        activateTab: function( tab ) {
+                if ( ! tab ) {
+                        return;
+                }
+
+                this.deactivateTabs( this.tabs );
+
+                // The tab is a DOM element: no need for jQuery methods.
+                tab.focus();
+
+                // Handle manual activation.
+                if ( ! this.tabsAutomaticActivation ) {
+                        tab.removeAttribute( 'tabindex' );
+                        tab.setAttribute( 'aria-selected', 'true' );
+                        return;
+                }
+
+                // Handle automatic activation.
+                $( tab ).on( 'click', function() {
+                        tab.removeAttribute( 'tabindex' );
+                        tab.setAttribute( 'aria-selected', 'true' );
+                } );
+
+                tab.click();
+        }
 });
 
 module.exports = FocusManager;

src/js/media/views/frame/post.js

@@ -257 +257 @@
         mainMenu: function( view ) {
                 view.set({
                         'library-separator': new wp.media.View({
-                                className: 'separator',
-                                priority: 100
+                                className:  'separator',
+                                priority:   100,
+                                attributes: {
+                                        role: 'presentation'
+                                }
                         })
                 });
         },

src/js/media/views/media-frame.js

@@ -110 +110 @@
          */
         createMenu: function( menu ) {
                 menu.view = new wp.media.view.Menu({
-                        controller: this
+                        controller: this,
+
+                        attributes: {
+                                role:               'tablist',
+                                'aria-orientation': 'vertical'
+                        }
                 });
         },
 

src/js/media/views/menu-item.js

@@ -11 +11 @@
  * @augments Backbone.View
  */
 MenuItem = wp.media.View.extend(/** @lends wp.media.view.MenuItem.prototype */{
-        tagName:   'a',
+        tagName:   'button',
         className: 'media-menu-item',
 
         attributes: {
-                href: '#'
+                type: 'button',
+                role: 'tab'
         },
 
         events: {
                 'click': '_click'
         },
+
         /**
-         * @param {Object} event
+         * Allows to override the click event.
          */
-        _click: function( event ) {
+        _click: function() {
                 var clickOverride = this.options.click;
 
-                if ( event ) {
-                        event.preventDefault();
-                }
-
                 if ( clickOverride ) {
                         clickOverride.call( this );
                 } else {
@@ -43 +41 @@
 
                 if ( state ) {
                         this.controller.setState( state );
+                        // Toggle the menu visibility in the responsive view.
                         this.views.parent.$el.removeClass( 'visible' ); // TODO: or hide on any click, see below
                 }
         },
+
         /**
          * @returns {wp.media.view.MenuItem} returns itself to allow chaining
          */

src/js/media/views/menu.js

@@ -20 +20 @@
         ItemView:  MenuItem,
         region:    'menu',
 
-        /* TODO: alternatively hide on any click anywhere
-        events: {
-                'click': 'click'
+        attributes: {
+                role:               'tablist',
+                'aria-orientation': 'horizontal'
         },
 
-        click: function() {
-                this.$el.removeClass( 'visible' );
+        initialize: function() {
+                this._views = {};
+
+                this.set( _.extend( {}, this._views, this.options.views ), { silent: true });
+                delete this.options.views;
+
+                if ( ! this.options.silent ) {
+                        this.render();
+                }
+
+                // Initialize the Focus Manager.
+                this.focusManager = new wp.media.view.FocusManager( {
+                        el:   this.el,
+                        mode: 'tabsNavigation'
+                } );
         },
-        */
 
         /**
          * @param {Object} options
@@ -47 +59 @@
                  */
                 PriorityList.prototype.ready.apply( this, arguments );
                 this.visibility();
+
+                // Set up aria tabs initial attributes.
+                this.focusManager.initializeAriaTabs();
         },
 
         set: function() {
@@ -87 +102 @@
 
                 this.deselect();
                 view.$el.addClass('active');
+
+                // Set up again the aria tabs initial attributes after the menu updates.
+                this.focusManager.initializeAriaTabs();
         },
 
         deselect: function() {

src/js/media/views/router.js

@@ -20 +20 @@
         ItemView:  wp.media.view.RouterItem,
         region:    'router',
 
+        attributes: {
+                role:               'tablist',
+                'aria-orientation': 'horizontal'
+        },
+
         initialize: function() {
                 this.controller.on( 'content:render', this.update, this );
                 // Call 'initialize' directly on the parent class.

src/wp-includes/css/media-views.css

@@ -553 +553 @@
         user-select: none;
 }
 
-.media-menu > a {
+.media-menu .media-menu-item {
         display: block;
+        box-sizing: border-box;
+        width: 100%;
         position: relative;
+        border: 0;
+        margin: 0;
         padding: 8px 20px;
-        margin: 0;
+        font-size: 14px;
         line-height: 1.28571428;
-        font-size: 14px;
+        background: transparent;
         color: #0073aa;
+        text-align: left;
         text-decoration: none;
+        cursor: pointer;
 }
 
-.media-menu > a:hover {
-        color: #0073aa;
+.media-menu .media-menu-item:hover {
         background: rgba(0, 0, 0, 0.04);
 }
 
-.media-menu > a:active {
+.media-menu .media-menu-item:active {
+        color: #0073aa;
         outline: none;
 }
 
@@ -579 +585 @@
         font-weight: 600;
 }
 
+.media-menu .media-menu-item:focus {
+        box-shadow:
+                0 0 0 1px #5b9dd9,
+                0 0 2px 1px rgba(30, 140, 190, 0.8);
+        color: #124964;
+        /* Only visible in Windows High Contrast mode */
+        outline: 1px solid transparent;
+}
+
 .media-menu .separator {
         height: 0;
         margin: 12px 20px;
@@ -594 +609 @@
         padding: 0 6px;
         margin: 0;
         clear: both;
-        -webkit-user-select: none;
-        -moz-user-select: none;
-        -ms-user-select: none;
-        user-select: none;
 }
 
-.media-router a {
-        transition: none;
-}
-
-.media-router > a {
+.media-router .media-menu-item {
         position: relative;
         float: left;
+        border: 0;
+        margin: 0;
         padding: 8px 10px 9px;
-        margin: 0;
         height: 18px;
         line-height: 1.28571428;
         font-size: 14px;
         text-decoration: none;
+        background: transparent;
+        cursor: pointer;
+        transition: none;
 }
 
-.media-router > a:last-child {
+.media-router .media-menu-item:last-child {
         border-right: 0;
 }
 
-.media-router > a:active {
-        outline: none;
+.media-router .media-menu-item:hover,
+.media-router .media-menu-item:active {
+        color: #0073aa;
 }
 
 .media-router .active,
 .media-router .active:hover {
-        color: #32373c;
+        color: #23282d;
 }
 
+.media-router .media-menu-item:focus {
+        box-shadow:
+                0 0 0 1px #5b9dd9,
+                0 0 2px 1px rgba(30, 140, 190, 0.8);
+        color: #124964;
+        /* Only visible in Windows High Contrast mode */
+        outline: 1px solid transparent;
+}
+
 .media-router .active,
-.media-router > a.active:last-child {
+.media-router .media-menu-item.active:last-child {
         margin: -1px -1px 0;
         background: #fff;
         border: 1px solid #ddd;