Ticket #47244: 47244.3.diff

src/wp-includes/formatting.php

@@ -3094 +3096 @@
                 $delimiter = trim( $rel_match[1] ) ? $rel_match[1] : '"';
                 $rel       = 'rel=' . $delimiter . trim( implode( ' ', $parts ) ) . $delimiter;
                 $link_html = str_replace( $rel_match[0], $rel, $link_html );
+        } elseif ( preg_match( '|target\s*=\s*?\\\\"|', $link_html ) ) {
+                $link_html .= " rel=\\\"$rel\\\"";
+        } elseif ( preg_match( '#(target|href)\s*=\s*?\'#', $link_html ) ) {
+                $link_html .= " rel='$rel'";
         } else {
                 $link_html .= " rel=\"$rel\"";
         }

tests/phpunit/tests/formatting/WPTargetedLinkRel.php

@@ -101 +101 @@
 
                 $this->assertEquals( $expected, $post->post_content );
         }
+
+        /**
+         * Ensure JSON format is preserved when relation attribute (rel) is missing.
+         *
+         * @ticket 46316
+         */
+        public function test_wp_targeted_link_rel_should_preserve_json() {
+                $content  = '<p>Links: <a href=\"\/\" target=\"_blank\">No rel<\/a><\/p>';
+                $expected = '<p>Links: <a href=\"\/\" target=\"_blank\" rel=\"noopener noreferrer\">No rel<\/a><\/p>';
+                $this->assertEquals( $expected, wp_targeted_link_rel( $content ) );
+        }
+
+        /**
+         * Ensure correct quotes are used when relation attribute (rel) is missing.
+         *
+         * @ticket 47244
+         */
+        public function test_wp_targeted_link_rel_should_use_correct_quotes() {
+                $content  = '<p>Links: <a href=\'\/\' target=\'_blank\'>No rel<\/a><\/p>';
+                $expected = '<p>Links: <a href=\'\/\' target=\'_blank\' rel=\'noopener noreferrer\'>No rel<\/a><\/p>';
+                $this->assertEquals( $expected, wp_targeted_link_rel( $content ) );
+
+                $content  = '<p>Links: <a href=\'\/\' target=_blank>No rel<\/a><\/p>';
+                $expected = '<p>Links: <a href=\'\/\' target=_blank rel=\'noopener noreferrer\'>No rel<\/a><\/p>';
+                $this->assertEquals( $expected, wp_targeted_link_rel( $content ) );
+        }
 }