Ticket #47678: 47678-some-unit-test-functions.patch

tests/phpunit/includes/abstract-testcase.php

@@ -909 +909 @@
          * @since 2.5.0
          * @since 3.8.0 Moved from `Tests_Query_Conditionals` to `WP_UnitTestCase`.
          *
-         * @param string ...$prop Any number of WP_Query properties that are expected to be true for the current request.
+         * @param string ...$true Any number of WP_Query properties that are expected to be true for the current request.
          */
-        public function assertQueryTrue() {
+        public function assertQueryTrue( ...$true ) {
                 global $wp_query;
-                $all  = array(
+                $all = array(
                         'is_404',
                         'is_admin',
                         'is_archive',
@@ -944 +944 @@
                         'is_trackback',
                         'is_year',
                 );
-                $true = func_get_args();
 
                 foreach ( $true as $true_thing ) {
                         $this->assertContains( $true_thing, $all, "Unknown conditional: {$true_thing}." );

tests/phpunit/includes/utils.php

@@ -128 +128 @@
                 return $arg . '_append';
         }
 
-        function filterall( $tag, $arg = null ) {
+        function filterall( $tag, ...$args ) {
                 // this one doesn't return the result, so it's safe to use with the new 'all' filter
                 if ( $this->debug ) {
                         dmp( __FUNCTION__, $this->current_filter() );
                 }
 
-                $args           = func_get_args();
                 $this->events[] = array(
                         'filter' => __FUNCTION__,
                         'tag'    => $tag,
-                        'args'   => array_slice( $args, 1 ),
+                        'args'   => $args,
                 );
         }
 
@@ -300 +299 @@
         return $out;
 }
 
-function dmp() {
-        $args = func_get_args();
-
+function dmp( ...$args ) {
         foreach ( $args as $thing ) {
                 echo ( is_scalar( $thing ) ? strval( $thing ) : var_export( $thing, true ) ), "\n";
         }

tests/phpunit/tests/customize/manager.php

@@ -2541 +2541 @@
          * Capture the actions fired when calling WP_Customize_Manager::set_post_value().
          *
          * @see Tests_WP_Customize_Manager::test_set_post_value()
+         *
+         * @param mixed ...$args Optional arguments passed to the action.
          */
-        function capture_customize_post_value_set_actions() {
+        function capture_customize_post_value_set_actions( ...$args ) {
                 $action = current_action();
-                $args   = func_get_args();
                 $this->captured_customize_post_value_set_actions[] = compact( 'action', 'args' );
         }
 

tests/phpunit/tests/hooks/doAction.php

@@ -164 +164 @@
 
         /**
          * Use this rather than MockAction so we can test callbacks with no args
+         *
+         * @param mixed ...$args Optional arguments passed to the action.
          */
-        public function _action_callback() {
-                $args           = func_get_args();
+        public function _action_callback( ...$args ) {
                 $this->events[] = array(
                         'action' => __FUNCTION__,
                         'args'   => $args,