Ticket #47684: 47684.2.diff

src/wp-includes/rest-api/class-wp-rest-server.php

@@ -564 +564 @@
                 $embedded = array();
 
                 foreach ( $data['_links'] as $rel => $links ) {
-                        // Ignore links to self, for obvious reasons.
-                        if ( 'self' === $rel ) {
-                                continue;
-                        }
-
                         $embeds = array();
 
                         foreach ( $links as $item ) {

tests/phpunit/tests/rest-api/rest-search-controller.php

@@ -500 +500 @@
                 $this->assertEqualSets( array( 'test_first_type', 'test_second_type', WP_REST_Search_Controller::TYPE_ANY ), $params[ WP_REST_Search_Controller::PROP_SUBTYPE ]['items']['enum'] );
         }
 
+        /**
+         * @ticket 47684
+         */
+        public function test_search_result_links_are_embedded() {
+                $response = $this->do_request_with_params( array( 'per_page' => 1 ) );
+                $data     = rest_get_server()->response_to_data( $response, true )[0];
+
+                $this->assertArrayHasKey( '_embedded', $data );
+                $this->assertArrayHasKey( 'self', $data['_embedded'] );
+                $this->assertCount( 1, $data['_embedded']['self'] );
+                $this->assertArrayHasKey( WP_REST_Search_Controller::PROP_ID, $data['_embedded']['self'][0] );
+                $this->assertEquals( $data[ WP_REST_Search_Controller::PROP_ID ], $data['_embedded']['self'][0][ WP_REST_Search_Controller::PROP_ID ] );
+        }
+
         /**
          * Perform a REST request to our search endpoint with given parameters.
          */

tests/phpunit/tests/rest-api/rest-server.php

@@ -569 +569 @@
 
         /**
          * @depends test_link_embedding
+         * @ticket 47684
          */
         public function test_link_embedding_self() {
                 // Register our testing route.
@@ -587 +588 @@
 
                 $data = rest_get_server()->response_to_data( $response, true );
 
-                $this->assertArrayNotHasKey( '_embedded', $data );
+                $this->assertArrayHasKey( '_embedded', $data );
         }
 
         /**