Ticket #47867: 47867.2.diff

src/wp-includes/formatting.php

@@ -3760 +3760 @@
  * to the number of individual characters.
  *
  * @since 3.3.0
+ * @since 5.3.0 `$num_words` will be set to 0 if null or non-numeric argument is passed.
  *
  * @param string $text      Text to trim.
  * @param int    $num_words Number of words. Default 55.
@@ -3774 +3775 @@
         $original_text = $text;
         $text          = wp_strip_all_tags( $text );
 
+        if ( ! is_numeric( $num_words ) ) {
+                $num_words = 0;
+        }
+
         /*
          * translators: If your word count is based on single characters (e.g. East Asian characters),
          * enter 'characters_excluding_spaces' or 'characters_including_spaces'. Otherwise, enter 'words'.

tests/phpunit/tests/formatting/WPTrimWords.php

@@ -35 +35 @@
                 $this->assertEquals( $trimmed, wp_trim_words( $text, 5 ) );
         }
 
+        /**
+         * @ticket 47867
+         */
+        function test_wp_trim_words_should_work_with_non_numeric_num_words() {
+                $text = 'This is more than 55 word data to test that wp_trim_words() should be returning the 0 words if the give $num_words argument is non-numeric. ' 
+                        . 'Numeric data even if they are passed as string still works. So the only concern are empty string or character non-numeric strings. ' 
+                        . 'Please see ticket #47867 for more information regarding this test.';
+                $trimmed = '';
+                $trimmed_3_words = 'This is more';
+
+                $this->assertEquals( $trimmed, wp_trim_words( $text, '', '' ) );
+                $this->assertEquals( $trimmed, wp_trim_words( $text, 'abc', '' ) );
+                $this->assertEquals( $trimmed, wp_trim_words( $text, null, '' ) );
+                $this->assertEquals( $trimmed_3_words, wp_trim_words( $text, '3', '' ) );
+        }
+
         // #18726
         function test_strips_script_and_style_content() {
                 $trimmed = 'This text contains. It should go.';