Ticket #48515: 48515.2.diff

wp-includes/class-wp-theme.php

@@ -35 +35 @@
                 'Tags'        => 'Tags',
                 'TextDomain'  => 'Text Domain',
                 'DomainPath'  => 'Domain Path',
+                'Requires'    => 'Requires at least',
+                'RequiresPHP' => 'Requires PHP',
         );
 
         /**
@@ -267 +269 @@
                         );
                         return;
                 } else {
-                        $this->headers = get_file_data( $this->theme_root . '/' . $theme_file, self::$file_headers, 'theme' );
+                        $this->headers = $this->get_theme_headers( $theme_dir, $theme_file );
+
                         // Default themes always trump their pretenders.
                         // Properly identify default themes that are inside a directory within wp-content/themes.
                         $default_theme_slug = array_search( $this->headers['Name'], self::$default_themes );
@@ -850 +853 @@
                                 $value = array_filter( array_map( 'trim', explode( ',', strip_tags( $value ) ) ) );
                                 break;
                         case 'Version':
+                        case 'Requires':
+                        case 'RequiresPHP':
                                 $value = strip_tags( $value );
                                 break;
                 }
@@ -1110 +1115 @@
                 return $this->theme_root_uri;
         }
 
+        /**
+         * Get headers from theme's style.css and readme.txt files.
+         *
+         * Uses `get_file_data()` to get and combine the theme headers
+         * from the theme's style.css and readme.txt files.
+         *
+         * Precedence order: readme.txt > style.css
+         *
+         * @since 5.x.x
+         *
+         * @param string $theme_dir  Directory of the theme within the theme_root.
+         * @param string $theme_file Main theme file.
+         *
+         * @return array Theme headers.
+         */
+        public function get_theme_headers( $theme_dir, $theme_file ) {
+                $theme_headers = get_file_data( $this->theme_root . '/' . $theme_file, self::$file_headers, 'theme' );
+
+                $readme = $this->theme_root . '/'. $theme_dir . '/readme.txt';
+                if ( file_exists( $readme ) ) {
+                        $readme_headers = get_file_data( $readme, self::$file_headers, 'theme' );
+
+                        // Precedence to headers in readme.txt over style.css file.
+                        foreach ( $theme_headers as $header => $value ) {
+                                if ( ! empty( $readme_headers[ $header ] ) ) {
+                                        $theme_headers[ $header ] = $readme_headers[ $header ];
+                                }
+                        }
+                }
+
+                // Many themes incorrectly use `Requires at least: WordPress x.x`, including default themes.
+                // It should only be the version number, `Requires at least: x.x`.
+                if ( false !== strpos( $theme_headers['Requires'], 'WordPress' ) ) {
+                        $theme_headers['Requires'] = trim( str_replace( 'WordPress', '', $theme_headers['Requires'] ) );
+                }
+
+                return $theme_headers;
+        }
+
         /**
          * Returns the main screenshot file for the theme.
          *