Ticket #48772: 48772.6.diff

src/wp-includes/comment-template.php

@@ -870 +870 @@
  * Displays the language string for the number of comments the current post has.
  *
  * @since 0.71
- * @since 5.4.0 Added the `$post_id` parameter.
+ * @since 5.4.0 The `$deprecated` parameter was changed to `$post_id`.
  *
  * @param string      $zero       Optional. Text for no comments. Default false.
  * @param string      $one        Optional. Text for one comment. Default false.
  * @param string      $more       Optional. Text for more than one comment. Default false.
- * @param string      $deprecated Not used.
  * @param int|WP_Post $post_id    Optional. Post ID or WP_Post object. Default is the global `$post`.
  */
-function comments_number( $zero = false, $one = false, $more = false, $deprecated = '', $post_id = 0 ) {
-        if ( ! empty( $deprecated ) ) {
-                _deprecated_argument( __FUNCTION__, '1.3.0' );
-        }
+function comments_number( $zero = false, $one = false, $more = false, $post_id = 0 ) {
         echo get_comments_number_text( $zero, $one, $more, $post_id );
 }
 

tests/phpunit/tests/comment/template.php

@@ -40 +40 @@
                 $comments_number_text = get_comments_number_text( false, false, false, $post_id );
 
                 $this->assertEquals( sprintf( _n( '%s Comment', '%s Comments', 6 ), '6' ), $comments_number_text );
+
+                ob_start();
+                comments_number( false, false, false, $post_id );
+                $comments_number_text = ob_get_clean();
+
+                $this->assertEquals( sprintf( _n( '%s Comment', '%s Comments', 6 ), '6' ), $comments_number_text );
+
         }
 
         /**