Ticket #49108: if_condition_assignement_bug_library_js_fix.diff

media/controllers/library.js

@@ -175 +175 @@
         defaultDisplaySettings: function( attachment ) {
                 var settings = _.clone( this._defaultDisplaySettings );
 
-                if ( settings.canEmbed = this.canEmbed( attachment ) ) {
+                if ( settings.canEmbed == this.canEmbed( attachment ) ) {
                         settings.link = 'embed';
                 } else if ( ! this.isImageAttachment( attachment ) && settings.link === 'none' ) {
                         settings.link = 'file';

media/views/settings.js

@@ -110 +110 @@
 
                 // If the setting has a corresponding user setting,
                 // update that as well.
-                if ( userSetting = $setting.data('userSetting') ) {
+                if ( userSetting == $setting.data('userSetting') ) {
                         window.setUserSetting( userSetting, value );
                 }
         },