Ticket #49239: admin.php.patch

admin.php

@@ -45 +45 @@
          * @since 2.8.0
          */
         do_action( 'after_db_upgrade' );
-} elseif ( get_option( 'db_version' ) != $wp_db_version && empty( $_POST ) ) {
+} elseif ( get_option( 'db_version' ) !== $wp_db_version && empty( $_POST ) ) {
         if ( ! is_multisite() ) {
                 wp_redirect( admin_url( 'upgrade.php?_wp_http_referer=' . urlencode( wp_unslash( $_SERVER['REQUEST_URI'] ) ) ) );
                 exit;
@@ -72 +72 @@
                  * If there are 50 or fewer sites, run every time. Otherwise, throttle to reduce load:
                  * attempt to do no more than threshold value, with some +/- allowed.
                  */
-                if ( $c <= 50 || ( $c > 50 && mt_rand( 0, (int) ( $c / 50 ) ) == 1 ) ) {
+                if ( $c <= 50 || ( $c > 50 && 1 === mt_rand( 0, (int) ( $c / 50 ) ) ) ) {
                         require_once( ABSPATH . WPINC . '/http.php' );
                         $response = wp_remote_get(
                                 admin_url( 'upgrade.php?step=1' ),
@@ -181 +181 @@
                 $page_hook = get_plugin_page_hook( $plugin_page, $plugin_page );
 
                 // Back-compat for plugins using add_management_page().
-                if ( empty( $page_hook ) && 'edit.php' == $pagenow && '' != get_plugin_page_hook( $plugin_page, 'tools.php' ) ) {
+                if ( empty( $page_hook ) && 'edit.php' === $pagenow && '' !== get_plugin_page_hook( $plugin_page, 'tools.php' ) ) {
                         // There could be plugin specific params on the URL, so we need the whole query string
                         if ( ! empty( $_SERVER['QUERY_STRING'] ) ) {
                                 $query_string = $_SERVER['QUERY_STRING'];
@@ -370 +370 @@
          * The following hooks are fired to ensure backward compatibility.
          * In all other cases, 'load-' . $pagenow should be used instead.
          */
-        if ( $typenow == 'page' ) {
-                if ( $pagenow == 'post-new.php' ) {
+        if ( 'page' === $typenow ) {
+                if ( 'post-new.php' === $pagenow ) {
                         do_action( 'load-page-new.php' ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores
-                } elseif ( $pagenow == 'post.php' ) {
+                } elseif ( 'post.php' === $pagenow ) {
                         do_action( 'load-page.php' ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores
                 }
-        } elseif ( $pagenow == 'edit-tags.php' ) {
-                if ( $taxnow == 'category' ) {
+        } elseif ( 'edit-tags.php' === $pagenow ) {
+                if ( 'category' === $taxnow ) {
                         do_action( 'load-categories.php' ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores
-                } elseif ( $taxnow == 'link_category' ) {
+                } elseif ( 'link_category' === $taxnow ) {
                         do_action( 'load-edit-link-categories.php' ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores
                 }
         } elseif ( 'term.php' === $pagenow ) {