Ticket #49239: install-helper.php.patch

install-helper.php

@@ -52 +52 @@
         function maybe_create_table( $table_name, $create_ddl ) {
                 global $wpdb;
                 foreach ( $wpdb->get_col( 'SHOW TABLES', 0 ) as $table ) {
-                        if ( $table == $table_name ) {
+                        if ( $table === $table_name ) {
                                 return true;
                         }
                 }
@@ -61 +61 @@
 
                 // We cannot directly tell that whether this succeeded!
                 foreach ( $wpdb->get_col( 'SHOW TABLES', 0 ) as $table ) {
-                        if ( $table == $table_name ) {
+                        if ( $table === $table_name ) {
                                 return true;
                         }
                 }
@@ -86 +86 @@
                 global $wpdb;
                 foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
 
-                        if ( $column == $column_name ) {
+                        if ( $column === $column_name ) {
                                 return true;
                         }
                 }
@@ -96 +96 @@
 
                 // We cannot directly tell that whether this succeeded!
                 foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
-                        if ( $column == $column_name ) {
+                        if ( $column === $column_name ) {
                                 return true;
                         }
                 }
@@ -119 +119 @@
 function maybe_drop_column( $table_name, $column_name, $drop_ddl ) {
         global $wpdb;
         foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
-                if ( $column == $column_name ) {
+                if ( $column === $column_name ) {
 
                         // Found it, so try to drop it.
                         $wpdb->query( $drop_ddl );
@@ -126 +126 @@
 
                         // We cannot directly tell that whether this succeeded!
                         foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
-                                if ( $column == $column_name ) {
+                                if ( $column === $column_name ) {
                                         return false;
                                 }
                         }
@@ -172 +172 @@
 
         foreach ( $results as $row ) {
 
-                if ( $row->Field == $col_name ) {
+                if ( $row->Field === $col_name ) {
 
                         // Got our column, check the params.
-                        if ( ( $col_type != null ) && ( $row->Type != $col_type ) ) {
+                        if ( ( $col_type != null ) && ( $row->Type !== $col_type ) ) {
                                 ++$diffs;
                         }
                         if ( ( $is_null != null ) && ( $row->Null != $is_null ) ) {
                                 ++$diffs;
                         }
-                        if ( ( $key != null ) && ( $row->Key != $key ) ) {
+                        if ( ( $key != null ) && ( $row->Key !== $key ) ) {
                                 ++$diffs;
                         }
-                        if ( ( $default != null ) && ( $row->Default != $default ) ) {
+                        if ( ( $default !== null ) && ( $row->Default !== $default ) ) {
                                 ++$diffs;
                         }
-                        if ( ( $extra != null ) && ( $row->Extra != $extra ) ) {
+                        if ( ( $extra !== null ) && ( $row->Extra !== $extra ) ) {
                                 ++$diffs;
                         }
                         if ( $diffs > 0 ) {