WordPress.org
Get WordPress

Make WordPress Core

Ticket #49295: 49295.10.diff

File 49295.10.diff, 5.3 KB (added by audrasjb, 6 years ago)

About page: remove text rotation on WordPress version and useless <em> tag as per accessibility team meeting statements

  • src/wp-admin/about.php 

    diff --git a/src/wp-admin/about.php b/src/wp-admin/about.php
index acaaa2a009..c14c1bfc50 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php';  
    2020
    2121                <div class="about__header">
    2222                        <div class="about__header-title">
    23                                 <h1>
     23                                <p>
    2424                                        <?php _e( 'WordPress' ); ?>
    2525                                        <span><?php echo $display_version; ?></span>
    26                                 </h1>
     26                                </p>
    2727                        </div>
    2828
    2929                        <div class="about__header-text">
    … … require_once ABSPATH . 'wp-admin/admin-header.php';  
    4141                </div>
    4242
    4343                <div class="about__section is-feature has-accent-background-color">
    44                         <p><?php _e( 'Say hello to more and better.' ); ?></p>
     44                        <h1><?php _e( 'Say hello to more and better.' ); ?></h1>
     45
    4546                        <p><?php _e( 'More ways to make your pages come alive. With easier ways to get it all done and looking better than ever&mdash;and boosts in speed you can feel.' ); ?></p>
    4647                </div>
    4748
    … … require_once ABSPATH . 'wp-admin/admin-header.php';  
    105106                                        <li><?php _e( 'Tips are gone. In their place, a Welcome Guide window you can bring up when you need it&mdash;and only when you need it&mdash;again and again.' ); ?></li>
    106107                                        <li><?php _e( 'Know at a glance whether you&#8217;re in a block&#8217;s Edit or Navigation mode. Or, if you have restricted vision, your screen reader will tell you which mode you&#8217;re in.' ); ?></li>
    107108                                </ul>
    108                                 <p><em><?php _e( 'Of course, if you want to work with the very latest tools and features, install the <a href="https://wordpress.org/plugins/gutenberg/">Gutenberg plugin</a>. You&#8217;ll get to be the first to use new and exciting features in the block editor, before anyone else has seen them!' ); ?></em></p>
     109                                <p><?php _e( 'Of course, if you want to work with the very latest tools and features, install the <a href="https://wordpress.org/plugins/gutenberg/">Gutenberg plugin</a>. You&#8217;ll get to be the first to use new and exciting features in the block editor, before anyone else has seen them!' ); ?></p>
    109110                        </div>
    110111                        <div class="column is-edge-to-edge">
    111112                                <div class="about__image aligncenter">

  • src/wp-admin/credits.php 

    diff --git a/src/wp-admin/credits.php b/src/wp-admin/credits.php
index 60b1ebb004..9ed12661c3 100644
    a b $credits = wp_credits();  
    2222
    2323        <div class="about__header">
    2424                <div class="about__header-title">
    25                         <h1>
     25                        <p>
    2626                                <?php _e( 'WordPress' ); ?>
    2727                                <span><?php echo $display_version; ?></span>
    28                         </h1>
     28                        </p>
    2929                </div>
    3030
    3131                <div class="about__header-text">
    … … $credits = wp_credits();  
    4444
    4545        <div class="about__section">
    4646                <div class="column">
    47                         <h2><?php _e( 'WordPress is created by a worldwide team of passionate individuals.' ); ?></h2>
     47                        <h1><?php _e( 'WordPress is created by a worldwide team of passionate individuals.' ); ?></h1>
    4848
    4949                        <p>
    5050                                <?php

  • src/wp-admin/css/about.css 

    diff --git a/src/wp-admin/css/about.css b/src/wp-admin/css/about.css
index 51e49261d6..2d37148cdf 100644
    a b  
    303303}
    304304
    305305.about__container h1 {
    306         font-size: 5em;
     306        font-size: 4em;
    307307        line-height: 1;
    308308}
    309309
    … …  
    448448        -ms-grid-row-span: 2;
    449449        grid-row: 1/span 2;
    450450        padding: 32px;
    451         -webkit-writing-mode: vertical-rl;
    452         -ms-writing-mode: tb-rl;
    453         writing-mode: vertical-rl;
    454         transform: rotate(180deg);
    455451}
    456452
    457453/* Needs to be inline-block to use vertical-align, needs specificity to override flex. */
    458454.about__header .about__header-title {
    459         display: inline-block;
     455        display: flex;
    460456        vertical-align: top;
    461457}
    462458
    … …  
    467463}
    468464
    469465.about__header-title h1 span {
    470         display: block;
     466        display: inline-block;
    471467        font-weight: 600;
    472468        font-size: 1.2em;
    473469        line-height: 1;

  • src/wp-admin/freedoms.php 

    diff --git a/src/wp-admin/freedoms.php b/src/wp-admin/freedoms.php
index c9bc298866..454a647c0d 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php';  
    2525
    2626        <div class="about__header">
    2727                <div class="about__header-title">
    28                         <h1>
     28                        <p>
    2929                                <?php _e( 'WordPress' ); ?>
    3030                                <span><?php echo $display_version; ?></span>
    31                         </h1>
     31                        </p>
    3232                </div>
    3333
    3434                <div class="about__header-text">
    … … require_once ABSPATH . 'wp-admin/admin-header.php';  
    4646        </div>
    4747
    4848        <div class="about__section has-subtle-background-color is-feature">
    49                 <h2><?php _e( 'Freedoms' ); ?></h2>
     49                <h1><?php _e( 'Freedoms' ); ?></h1>
    5050
    5151                <p class="about-description">
    5252                <?php

  • src/wp-admin/privacy.php 

    diff --git a/src/wp-admin/privacy.php b/src/wp-admin/privacy.php
index 09248661bb..2ef4258e33 100644
    a b require_once ABSPATH . 'wp-admin/admin-header.php';  
    1919
    2020        <div class="about__header">
    2121                <div class="about__header-title">
    22                         <h1>
     22                        <p>
    2323                                <?php _e( 'WordPress' ); ?>
    2424                                <span><?php echo $display_version; ?></span>
    25                         </h1>
     25                        </p>
    2626                </div>
    2727
    2828                <div class="about__header-text">
    … … require_once ABSPATH . 'wp-admin/admin-header.php';  
    4141
    4242        <div class="about__section">
    4343                <div class="column">
    44                         <h2><?php _e( 'Privacy' ); ?></h2>
     44                        <h1><?php _e( 'Privacy' ); ?></h1>
    4545
    4646                        <p><?php _e( 'From time to time, your WordPress site may send data to WordPress.org &#8212; including, but not limited to &#8212; the version of WordPress you are using, and a list of installed plugins and themes.' ); ?></p>
    4747