Ticket #49317: Javascript_Coding_Standards.patch

src/js/_enqueues/wp/media/editor.js

@@ -164 +164 @@
                         var shortcode, html, extension;
 
                         props = wp.media.string.props( props, attachment );
-                        if ( props.link !== 'embed' )
-                                return wp.media.string.link( props );
+                        if ( props.link !== 'embed' ) {
+                                return wp.media.string.link(props);
+                        }
 
                         shortcode = {};
 
@@ -446 +447 @@
 
                                 if ( attrs._orderbyRandom ) {
                                         attrs.orderby = 'rand';
-                                } else if ( attrs._orderByField && attrs._orderByField != 'rand' ) {
+                                } else if ( attrs._orderByField && attrs._orderByField !== 'rand' ) {
                                         attrs.orderby = attrs._orderByField;
                                 }
 
@@ -625 +626 @@
                                 thumbnail_id: settings.post.featuredImageId,
                                 _wpnonce:     settings.post.nonce
                         }).done( function( html ) {
-                                if ( html == '0' ) {
+                                if ( html === '0' ) {
                                         window.alert( window.setPostThumbnailL10n.error );
                                         return;
                                 }
@@ -801 +802 @@
 
                                 selection = selection || state.get('selection');
 
-                                if ( ! selection )
+                                if ( ! selection ) {
                                         return;
+                                }
 
                                 $.when.apply( $, selection.map( function( attachment ) {
                                         var display = state.display( attachment ).toJSON();
@@ -965 +967 @@
                                                 size:  'image-size',
                                                 alt:   'image_alt'
                                         }, function( option, prop ) {
-                                                if ( props[ prop ] )
+                                                if ( props[ prop ] ){
                                                         options[ option ] = props[ prop ];
+                                                }
                                         });
                                 } else if ( 'video' === attachment.type ) {
                                         html = wp.media.string.video( props, attachment );