Ticket #49399: 49399.1.patch

src/wp-includes/user.php

@@ -2708 +2708 @@
         }
 
         $regex = implode( '|', array_keys( $role_names ) );
-        $regex = preg_replace( '/[^a-zA-Z_\|-]/', '', $regex );
+        $regex = preg_replace( '/[^0-9a-zA-Z_\|-]/', '', $regex );
         $users = $wpdb->get_col(
                 $wpdb->prepare(
                         "

tests/phpunit/tests/user/wpGetUsersWithNoRole.php

@@ -109 +109 @@
          * Role comparison must be done on role name, not role display name.
          *
          * @ticket 38234
+         * @ticket 49399
          */
         public function test_get_users_with_no_role_matches_on_role_name() {
                 // Create a role with a display name which would not match the role name
                 // in a case-insentive SQL query.
                 wp_roles()->add_role( 'somerole', 'Some role display name' );
+                wp_roles()->add_role( 'role2', 'Another role with display name' );
+                wp_roles()->add_role( 'Group1Admins', 'group admin' );
 
                 $someuser = self::factory()->user->create(
                         array(
@@ -121 +124 @@
                         )
                 );
 
+                $someuser2 = self::factory()->user->create(
+                        array(
+                                'role' => 'role2',
+                        )
+                );
+
+                $someuser3 = self::factory()->user->create(
+                        array(
+                                'role' => 'Group1Admins',
+                        )
+                );
+
                 $users = wp_get_users_with_no_role();
 
                 wp_roles()->remove_role( 'somerole' );
+                wp_roles()->remove_role( 'role2' );
+                wp_roles()->remove_role( 'Group1Admins' );
 
                 $this->assertEmpty( $users );
         }