Ticket #50038: 50038.diff

src/wp-admin/includes/class-wp-debug-data.php

@@ -519 +519 @@
                         'value' => ( is_array( $imagick_version ) ? $imagick_version['versionString'] : $imagick_version ),
                 );
 
+                if ( ! function_exists( 'ini_get' ) ) {
+                        $info['wp-media']['fields']['ini_get'] = array(
+                                'label' => __( 'File upload settings' ),
+                                'value' => sprintf(
+                                        /* translators: %s: ini_get() */
+                                        __( 'Unable to determine some settings, as the %s function has been disabled.' ),
+                                        'ini_get()'
+                                ),
+                                'debug' => 'ini_get() is disabled',
+                        );
+                } else {
+                        // Get the PHP ini directive values.
+                        $post_max_size    = ini_get( 'post_max_size' );
+                        $upload_max_size  = ini_get( 'upload_max_filesize' );
+                        $max_file_uploads = ini_get( 'max_file_uploads' );
+                        $effective        = min( WP_Site_Health::parse_ini_size( $post_max_size ), WP_Site_Health::parse_ini_size( $upload_max_size ) );
+                        // Add info in Media section.
+                        $info['wp-media']['fields']['file_uploads']        = array(
+                                'label' => __( 'File uploads' ),
+                                'value' => empty( ini_get( 'file_uploads' ) ) ? __( 'Disabled' ) : __( 'Enabled' ),
+                                'debug' => 'File uploads is turned off',
+                        );
+                        $info['wp-media']['fields']['post_max_size']       = array(
+                                'label' => __( 'Max size of post data allowed' ),
+                                'value' => $post_max_size,
+                        );
+                        $info['wp-media']['fields']['upload_max_filesize'] = array(
+                                'label' => __( 'Max size of an uploaded file' ),
+                                'value' => $upload_max_size,
+                        );
+                        $info['wp-media']['fields']['upload_max']          = array(
+                                'label' => __( 'Max effective file size' ),
+                                'value' => size_format( $effective ),
+                        );
+                        $info['wp-media']['fields']['max_file_uploads']    = array(
+                                'label' => __( 'Max number of files allowed' ),
+                                'value' => number_format( $max_file_uploads ),
+                        );
+                }
+
                 // If Imagick is used as our editor, provide some more information about its limitations.
                 if ( 'WP_Image_Editor_Imagick' === _wp_image_editor_choose() && isset( $imagick ) && $imagick instanceof Imagick ) {
                         $limits = array(

src/wp-admin/includes/class-wp-site-health.php

@@ -1956 +1956 @@
         }
 
         /**
+         * Test if 'file_uploads' directive in PHP.ini is turned off
+         *
+         * @since 5.5.0
+         *
+         * @return array The test results.
+         */
+        public function get_test_file_uploads() {
+                $result = array(
+                        'label'       => __( 'File uploads is on in PHP ini' ),
+                        'status'      => 'good',
+                        'badge'       => array(
+                                'label' => __( 'Media' ),
+                                'color' => 'blue',
+                        ),
+                        'description' => sprintf(
+                                '<p>%s</p>',
+                                __( 'The <code>file_uploads</code> directive in <code>php.ini</code> determines if uploading to is allowed in your WordPress.' )
+                        ),
+                        'actions'     => '',
+                        'test'        => 'file_uploads',
+                );
+
+                if ( ! function_exists( 'ini_get' ) ) {
+                        $result['status']       = 'critical';
+                        $result['description'] .= sprintf(
+                                /* translators: %s: ini_get() */
+                                __( 'Unable to determine some settings, as the %s function has been disabled.' ),
+                                'ini_get()'
+                        );
+                        return $result;
+                }
+
+                if ( empty( ini_get( 'file_uploads' ) ) ) {
+                        $result['status']       = 'critical';
+                        $result['description'] .= sprintf(
+                                '<p>%s</p>',
+                                __( '<code>file_uploads</code> is set to <code>0</code>. You won\'t be able to upload files in your WordPress.' )
+                        );
+                        return $result;
+                }
+
+                if ( $this->parse_ini_size( ini_get( 'post_max_size' ) ) !== $this->parse_ini_size( ini_get( 'upload_max_filesize' ) ) ) {
+                        $result['label']       = __( 'Mismatched "post_max_size" and "upload_max_filesize" values.' );
+                        $result['status']      = 'recommended';
+                        $result['description'] = sprintf(
+                                '<p>%s</p>',
+                                __( 'Mismatched values for PHP INI directives <code>post_max_size</code> and <code>upload_max_filesize</code> may cause problems. These values are in PHP INI.' )
+                        );
+                        return $result;
+                }
+
+                return $result;
+        }
+
+        /**
          * Return a set of tests that belong to the site status page.
          *
          * Each site status test is defined here, they may be `direct` tests, that run on page load, or `async` tests
@@ -2025 +2080 @@
                                         'label' => __( 'Debugging enabled' ),
                                         'test'  => 'is_in_debug_mode',
                                 ),
+                                'file_uploads'         => array(
+                                        'label' => __( 'File uploads' ),
+                                        'test'  => 'file_uploads',
+                                ),
                         ),
                         'async'  => array(
                                 'dotorg_communication' => array(

src/wp-includes/functions.php

@@ -477 +477 @@
 }
 
 /**
+ * Converts a shorthand byte string to bytes.
+ *
+ * Useful when needing to compare two byte strings for size differences.
+ *
+ * E.g.
+ *  "1G" (1 Gigabyte) = 1073741824
+ *  "10M" (10 Megabytes) = 10485760
+ *  "1K" (1 Kilobyte) = 1024
+ *
+ * @since 5.5.0
+ *
+ * @param  string $size_string Shorthand byte string
+ * @return int                 $size_string converted to numberic bytes.
+ */
+function parse_ini_size( $size_string ) {
+        $size_string = trim( $size_string );
+        $last        = strtolower( substr( $size_string, - 1 ) );
+        $value       = intval( $size_string );
+
+        switch ( $last ) {
+                case 'g':
+                        return (int) $value * GB_IN_BYTES;
+                case 'm':
+                        return (int) $value * MB_IN_BYTES;
+                case 'k':
+                        return (int) $value * KB_IN_BYTES;
+                default:
+                        return (int) $value;
+        }
+}
+
+/**
  * Convert a duration to human readable format.
  *
  * @since 5.1.0