Ticket #50105: 50105.diff

src/js/media/models/attachments.js

@@ -355 +355 @@
         hasMore: function() {
                 return this.mirroring ? this.mirroring.hasMore() : false;
         },
+
         /**
+         * Holds the total number of attachments.
+         *
+         * @since 5.5.0
+         */
+        totalAttachments: 0,
+
+        /**
+         * Gets the total number of attachments.
+         *
+         * @since 5.5.0
+         *
+         * @return {number} The total number of attachments.
+         */
+        getTotalAttachments: function() {
+                return this.mirroring ? this.mirroring.totalAttachments : 0;
+        },
+
+        /**
          * A custom AJAX-response parser.
          *
          * See trac ticket #24753
          *
-         * @param {Object|Array} resp The raw response Object/Array.
+         * Called automatically by Backbone whenever a collection's models are returned
+         * by the server, in fetch. The default implementation is a no-op, simply
+         * passing through the JSON response. We override this to add attributes to
+         * the collection items.
+         *
+         * Since WordPress 5.5, the response returns the attachments under `response.attachments`
+         * and `response.totalAttachments` holds the total number of attachments found.
+         *
+         * @param {Object|Array} response The raw response Object/Array.
          * @param {Object} xhr
          * @return {Array} The array of model attributes to be added to the collection
          */
-        parse: function( resp, xhr ) {
-                if ( ! _.isArray( resp ) ) {
-                        resp = [resp];
+        parse: function( response, xhr ) {
+                if ( ! _.isArray( response.attachments ) ) {
+                        response = [response.attachments];
                 }
 
-                return _.map( resp, function( attrs ) {
+                this.totalAttachments = parseInt( response.totalAttachments, 10 );
+
+                return _.map( response.attachments, function( attrs ) {
                         var id, attachment, newAttributes;
 
                         if ( attrs instanceof Backbone.Model ) {

src/js/media/models/query.js

@@ -112 +112 @@
                 options = options || {};
                 options.remove = false;
 
-                return this._more = this.fetch( options ).done( function( resp ) {
-                        if ( _.isEmpty( resp ) || -1 === this.args.posts_per_page || resp.length < this.args.posts_per_page ) {
+                return this._more = this.fetch( options ).done( function( response ) {
+                        // Since WordPress 5.5, the response returns the attachments under `response.attachments`.
+                        var attachments = response.attachments;
+
+                        if ( _.isEmpty( attachments ) || -1 === this.args.posts_per_page || attachments.length < this.args.posts_per_page ) {
                                 query._hasMore = false;
                         }
                 });

src/js/media/views/attachments/browser.js

@@ -2 +2 @@
         mediaTrash = wp.media.view.settings.mediaTrash,
         l10n = wp.media.view.l10n,
         $ = jQuery,
-        AttachmentsBrowser;
+        AttachmentsBrowser,
+        infiniteScrolling = wp.media.view.settings.infiniteScrolling,
+        __ = wp.i18n.__,
+        sprintf = wp.i18n.sprintf;
 
 /**
  * wp.media.view.AttachmentsBrowser
@@ -68 +71 @@
                         this.createUploader();
                 }
 
-
                 // Add a heading before the attachments list.
                 this.createAttachmentsHeading();
 
-                // Create the list of attachments.
-                this.createAttachments();
+                // Create the attachments wrapper view.
+                this.createAttachmentsWrapperView();
 
+                if ( ! infiniteScrolling ) {
+                        this.$el.addClass( 'has-load-more' );
+                        this.createLoadMoreView();
+                }
+
                 // For accessibility reasons, place the normal sidebar after the attachments, see ticket #36909.
                 if ( this.options.sidebar && 'errors' !== this.options.sidebar ) {
                         this.createSidebar();
@@ -92 +99 @@
 
                 this.collection.on( 'add remove reset', this.updateContent, this );
 
+                if ( ! infiniteScrolling ) {
+                        this.collection.on( 'add remove reset', this.updateLoadMoreView, this );
+                }
+
                 // The non-cached or cached attachments query has completed.
                 this.collection.on( 'attachments:received', this.announceSearchResults, this );
         },
@@ -392 +403 @@
                         noItemsView;
 
                 if ( this.controller.isModeActive( 'grid' ) ) {
+                        // Usually the media library.
                         noItemsView = view.attachmentsNoResults;
                 } else {
+                        // Usually the media modal.
                         noItemsView = view.uploader;
                 }
 
@@ -433 +446 @@
                 }
         },
 
+        /**
+         * Creates the Attachments wrapper view.
+         *
+         * @since 5.5.0
+         *
+         * @return {void}
+         */
+        createAttachmentsWrapperView: function() {
+                this.attachmentsWrapper = new wp.media.View( {
+                        className: 'attachments-wrapper'
+                } );
+
+                // Create the list of attachments.
+                this.views.add( this.attachmentsWrapper );
+                this.createAttachments();
+        },
+
         createAttachments: function() {
                 this.attachments = new wp.media.view.Attachments({
                         controller:           this.controller,
@@ -451 +481 @@
                 this.controller.on( 'attachment:keydown:arrow',     _.bind( this.attachments.arrowEvent, this.attachments ) );
                 this.controller.on( 'attachment:details:shift-tab', _.bind( this.attachments.restoreFocus, this.attachments ) );
 
-                this.views.add( this.attachments );
+                this.views.add( '.attachments-wrapper', this.attachments );
 
-
                 if ( this.controller.isModeActive( 'grid' ) ) {
                         this.attachmentsNoResults = new View({
                                 controller: this.controller,
@@ -467 +496 @@
                 }
         },
 
+        /**
+         * Creates the load more button and attachments counter view.
+         *
+         * @since 5.5.0
+         *
+         * @return {void}
+         */
+        createLoadMoreView: function() {
+                var view = this;
+
+                this.loadMoreButton = new wp.media.view.Button( {
+                        text: l10n.loadMore,
+                        className: 'load-more hidden',
+                        style: 'primary',
+                        size: 'hero',
+                        click: function() {
+                                view.loadMoreAttachments();
+                        }
+                } );
+
+                this.loadMoreCount = new View( {
+                        controller: this.controller,
+                        tagName: 'p',
+                        className: 'load-more-count hidden'
+                } );
+
+                this.loadMoreSpinner = new wp.media.view.Spinner();
+
+                this.views.add( '.attachments-wrapper', this.loadMoreCount );
+                this.views.add( '.attachments-wrapper', this.loadMoreButton );
+                this.views.add( '.attachments-wrapper', this.loadMoreSpinner );
+        },
+
+        /**
+         * Updates the Load More view. This function is debounced because the
+         * collection updates multiple times at the add, remove, and reset events.
+         * We need it to run only once, after all attachments are added or removed.
+         *
+         * @since 5.5.0
+         *
+         * @return {void}
+         */
+        updateLoadMoreView: _.debounce( function() {
+                // Ensure the load more view elements are initially hidden at each update.
+                this.loadMoreButton.$el.addClass( 'hidden' );
+                this.loadMoreCount.$el.addClass( 'hidden' );
+
+                if ( ! this.collection.getTotalAttachments() ) {
+                        return;
+                }
+
+                if ( this.collection.length ) {
+                        this.loadMoreCount.$el.text(
+                                /* translators: 1: Number of displayed attachments, 2: Number of total attachments. */
+                                sprintf(
+                                        __( 'Media items %1$s of %2$s' ),
+                                        this.collection.length,
+                                        this.collection.getTotalAttachments()
+                                )
+                        );
+
+                        this.loadMoreCount.$el.removeClass( 'hidden' );
+                }
+
+                /*
+                 * Notice that while the collection updates multiple times hasMore() may
+                 * return true when it's actually not true.
+                 */
+                if ( this.collection.hasMore() ) {
+                        this.loadMoreButton.$el.removeClass( 'hidden' );
+                }
+        }, 10 ),
+
+        /**
+         * Loads more attachments.
+         *
+         * @since 5.5.0
+         *
+         * @return {void}
+         */
+        loadMoreAttachments: function() {
+                var view = this,
+                        loadMoreSpinner = this.loadMoreSpinner,
+                        firstAddedMediaItemIndex;
+
+                if ( ! this.collection.hasMore() ) {
+                        return;
+                }
+
+                // Collection index starts from 0.
+                firstAddedMediaItemIndex = this.collection.length;
+
+                loadMoreSpinner.show();
+
+                this.collection.more().done( function() {
+                        // Within done(), `this` is the returned collection.
+                        loadMoreSpinner.hide();
+                        // Set focus on first added item.
+                        view.$el.find( 'li' ).eq( firstAddedMediaItemIndex ).focus();
+                } );
+        },
+
         createAttachmentsHeading: function() {
                 this.attachmentsHeading = new wp.media.view.Heading( {
                         text: l10n.attachmentsList,

src/js/media/views/attachments.js

@@ -1 +1 @@
 var View = wp.media.View,
         $ = jQuery,
-        Attachments;
+        Attachments,
+        infiniteScrolling = wp.media.view.settings.infiniteScrolling;
 
 Attachments = View.extend(/** @lends wp.media.view.Attachments.prototype */{
         tagName:   'ul',
@@ -35 +36 @@
                 this.el.id = _.uniqueId('__attachments-view-');
 
                 /**
+                 * @param infiniteScrolling  Whether to enable infinite scrolling or use
+                 *                           the default "load more" button.
                  * @param refreshSensitivity The time in milliseconds to throttle the scroll
                  *                           handler.
                  * @param refreshThreshold   The amount of pixels that should be scrolled before
@@ -49 +52 @@
                  *                           calculating the total number of columns.
                  */
                 _.defaults( this.options, {
+                        infiniteScrolling:  infiniteScrolling || false,
                         refreshSensitivity: wp.media.isTouchDevice ? 300 : 200,
                         refreshThreshold:   3,
                         AttachmentView:     wp.media.view.Attachment,
@@ -84 +88 @@
 
                 this.controller.on( 'library:selection:add', this.attachmentFocus, this );
 
-                // Throttle the scroll handler and bind this.
-                this.scroll = _.chain( this.scroll ).bind( this ).throttle( this.options.refreshSensitivity ).value();
+                if ( this.options.infiniteScrolling ) {
+                        // Throttle the scroll handler and bind this.
+                        this.scroll = _.chain( this.scroll ).bind( this ).throttle( this.options.refreshSensitivity ).value();
 
-                this.options.scrollElement = this.options.scrollElement || this.el;
-                $( this.options.scrollElement ).on( 'scroll', this.scroll );
+                        this.options.scrollElement = this.options.scrollElement || this.el;
+                        $( this.options.scrollElement ).on( 'scroll', this.scroll );
+                }
 
                 this.initSortable();
 
@@ -387 +393 @@
                         this.views.set( this.collection.map( this.createAttachmentView, this ) );
                 } else {
                         this.views.unset();
-                        this.collection.more().done( this.scroll );
+                        if ( this.options.infiniteScrolling ) {
+                                this.collection.more().done( this.scroll );
+                        }
                 }
         },
 
@@ -400 +408 @@
          * @return {void}
          */
         ready: function() {
-                this.scroll();
+                if ( this.options.infiniteScrolling ) {
+                        this.scroll();
+                }
         },
 
         /**

src/wp-admin/css/media.css

@@ -416 +416 @@
 
 .media-frame.mode-grid,
 .media-frame.mode-grid .media-frame-content,
-.media-frame.mode-grid .attachments-browser .attachments,
+.media-frame.mode-grid .attachments-browser:not(.has-load-more) .attachments,
+.media-frame.mode-grid .attachments-browser.has-load-more .attachments-wrapper,
 .media-frame.mode-grid .uploader-inline-content {
         position: static;
 }
@@ -494 +495 @@
         border: 4px dashed #b4b9be;
 }
 
-.media-frame.mode-select .attachments-browser.fixed .attachments {
+.media-frame.mode-select .attachments-browser.fixed:not(.has-load-more) .attachments,
+.media-frame.mode-select .attachments-browser.has-load-more.fixed .attachments-wrapper {
         position: relative;
         top: 94px; /* prevent jumping up when the toolbar becomes fixed */
         padding-bottom: 94px; /* offset for above so the bottom doesn't get cut off */

src/wp-admin/includes/ajax-actions.php

@@ -2969 +2969 @@
         $posts = array_map( 'wp_prepare_attachment_for_js', $query->posts );
         $posts = array_filter( $posts );
 
-        wp_send_json_success( $posts );
+        $result = array(
+                'attachments'      => $posts,
+                'totalAttachments' => $query->found_posts,
+        );
+
+        wp_send_json_success( $result );
 }
 
 /**

src/wp-includes/css/media-views.css

@@ -1170 +1170 @@
         padding: 2px 8px 8px;
 }
 
-.attachments-browser .attachments,
+.attachments-browser:not(.has-load-more) .attachments,
+.attachments-browser.has-load-more .attachments-wrapper,
 .attachments-browser .uploader-inline {
         position: absolute;
         top: 72px;
@@ -1249 +1250 @@
         padding: 2em 0 0 2em;
 }
 
+.attachments-browser .load-more-count {
+        clear: both;
+        text-align: center;
+}
+
+.attachments-browser .load-more {
+        display: block;
+        margin: 1em auto;
+}
+
+.media-frame .attachments-browser .load-more + .spinner {
+        display: block;
+        float: none;
+        margin: 8px auto 16px;
+}
+
 /**
  * Progress Bar
  */

src/wp-includes/media.php

@@ -3969 +3969 @@
                 );
         }
 
+        /**
+         * Filters whether the Media Library grid has infinite scrolling. Default `false`.
+         *
+         * @since 5.5.0
+         *
+         * @param bool $value The filtered value, defaults to `false`.
+         */
+        $infinite_scrolling = apply_filters( 'media_library_infinite_scrolling', false );
+
         $settings = array(
-                'tabs'             => $tabs,
-                'tabUrl'           => add_query_arg( array( 'chromeless' => true ), admin_url( 'media-upload.php' ) ),
-                'mimeTypes'        => wp_list_pluck( get_post_mime_types(), 0 ),
+                'tabs'              => $tabs,
+                'tabUrl'            => add_query_arg( array( 'chromeless' => true ), admin_url( 'media-upload.php' ) ),
+                'mimeTypes'         => wp_list_pluck( get_post_mime_types(), 0 ),
                 /** This filter is documented in wp-admin/includes/media.php */
-                'captions'         => ! apply_filters( 'disable_captions', '' ),
-                'nonce'            => array(
+                'captions'          => ! apply_filters( 'disable_captions', '' ),
+                'nonce'             => array(
                         'sendToEditor' => wp_create_nonce( 'media-send-to-editor' ),
                 ),
-                'post'             => array(
+                'post'              => array(
                         'id' => 0,
                 ),
-                'defaultProps'     => $props,
-                'attachmentCounts' => array(
+                'defaultProps'      => $props,
+                'attachmentCounts'  => array(
                         'audio' => ( $show_audio_playlist ) ? 1 : 0,
                         'video' => ( $show_video_playlist ) ? 1 : 0,
                 ),
-                'oEmbedProxyUrl'   => rest_url( 'oembed/1.0/proxy' ),
-                'embedExts'        => $exts,
-                'embedMimes'       => $ext_mimes,
-                'contentWidth'     => $content_width,
-                'months'           => $months,
-                'mediaTrash'       => MEDIA_TRASH ? 1 : 0,
+                'oEmbedProxyUrl'    => rest_url( 'oembed/1.0/proxy' ),
+                'embedExts'         => $exts,
+                'embedMimes'        => $ext_mimes,
+                'contentWidth'      => $content_width,
+                'months'            => $months,
+                'mediaTrash'        => MEDIA_TRASH ? 1 : 0,
+                'infiniteScrolling' => ( $infinite_scrolling ) ? 1 : 0,
         );
 
         $post = null;
@@ -4023 +4033 @@
                 $post_type_object = get_post_type_object( 'post' );
         }
 
+        /* translators: Accessibility text. %d: Number of attachments found in a search. */
+        $media_found_has_more_results = __( 'Number of media items displayed: %d. Click load more for more results.' );
+        if ( $infinite_scrolling ) {
+                /* translators: Accessibility text. %d: Number of attachments found in a search. */
+                $media_found_has_more_results = __( 'Number of media items displayed: %d. Scroll the page for more results.' );
+        }
+
         $strings = array(
                 // Generic.
                 'mediaFrameDefaultTitle'      => __( 'Media' ),
@@ -4075 +4092 @@
                 'searchLabel'                 => __( 'Search' ),
                 'searchMediaLabel'            => __( 'Search Media' ),          // Backward compatibility pre-5.3.
                 'searchMediaPlaceholder'      => __( 'Search media items...' ), // Placeholder (no ellipsis), backward compatibility pre-5.3.
+                /* translators: %d: Number of attachments found in a search. */
                 'mediaFound'                  => __( 'Number of media items found: %d' ),
-                'mediaFoundHasMoreResults'    => __( 'Number of media items displayed: %d. Scroll the page for more results.' ),
+                'mediaFoundHasMoreResults'    => $media_found_has_more_results,
                 'noMedia'                     => __( 'No media items found.' ),
                 'noMediaTryNewSearch'         => __( 'No media items found. Try a different search.' ),
+                'loadMore'                    => __( 'Load more' ),
 
                 // Library Details.
                 'attachmentDetails'           => __( 'Attachment Details' ),