Make WordPress Core

Ticket #50328: 50328.3.patch

File 50328.3.patch, 3.1 KB (added by hellofromTonya, 5 years ago)

Renames filter and function for consistency

  • src/wp-includes/blocks.php

    diff --git a/src/wp-includes/blocks.php b/src/wp-includes/blocks.php
    index 9a552835f7..e9dcdfbf7c 100644
    a b function register_block_style_handle( $metadata, $field_name ) { 
    158158                return false;
    159159        }
    160160        $is_core_block = isset( $metadata['file'] ) && 0 === strpos( $metadata['file'], ABSPATH . WPINC );
    161         if ( $is_core_block && ! should_load_separate_core_block_assets() ) {
     161        if ( $is_core_block && ! wp_should_load_separate_core_block_assets() ) {
    162162                return false;
    163163        }
    164164
  • src/wp-includes/script-loader.php

    diff --git a/src/wp-includes/script-loader.php b/src/wp-includes/script-loader.php
    index 515622825a..16a5f07d09 100644
    a b function wp_default_styles( $styles ) { 
    15721572                $handle = 'wp-' . $package;
    15731573                $path   = "/wp-includes/css/dist/$package/style$suffix.css";
    15741574
    1575                 if ( 'block-library' === $package && should_load_separate_core_block_assets() ) {
     1575                if ( 'block-library' === $package && wp_should_load_separate_core_block_assets() ) {
    15761576                        $path = "/wp-includes/css/dist/$package/common$suffix.css";
    15771577                }
    15781578                $styles->add( $handle, $path, $dependencies );
    function wp_should_load_block_editor_scripts_and_styles() { 
    22782278 *
    22792279 * @return bool Whether separate assets will be loaded or not.
    22802280 */
    2281 function should_load_separate_core_block_assets() {
     2281function wp_should_load_separate_core_block_assets() {
    22822282        if ( is_admin() || is_feed() || ( defined( 'REST_REQUEST' ) && REST_REQUEST ) ) {
    22832283                return false;
    22842284        }
    function should_load_separate_core_block_assets() { 
    22922292         * @param bool $load_separate_assets Whether separate assets will be loaded or not.
    22932293         *                                   Default false.
    22942294         */
    2295         return apply_filters( 'separate_core_block_assets', false );
     2295        return apply_filters( 'should_load_separate_core_block_assets', false );
    22962296}
    22972297
    22982298/**
    function should_load_separate_core_block_assets() { 
    23062306function wp_enqueue_registered_block_scripts_and_styles() {
    23072307        global $current_screen;
    23082308
    2309         if ( should_load_separate_core_block_assets() ) {
     2309        if ( wp_should_load_separate_core_block_assets() ) {
    23102310                return;
    23112311        }
    23122312
  • tests/phpunit/tests/dependencies/styles.php

    diff --git a/tests/phpunit/tests/dependencies/styles.php b/tests/phpunit/tests/dependencies/styles.php
    index c3b04bbdac..444430719a 100644
    a b CSS; 
    429429         * @covers ::wp_default_styles
    430430         */
    431431        function test_block_styles_for_viewing_without_split_styles() {
    432                 add_filter( 'separate_core_block_assets', '__return_false' );
     432                add_filter( 'should_load_separate_core_block_assets', '__return_false' );
    433433                wp_default_styles( $GLOBALS['wp_styles'] );
    434434
    435435                $this->assertSame(
    CSS; 
    446446         * @covers ::wp_default_styles
    447447         */
    448448        function test_block_styles_for_viewing_with_split_styles() {
    449                 add_filter( 'separate_core_block_assets', '__return_true' );
     449                add_filter( 'should_load_separate_core_block_assets', '__return_true' );
    450450                wp_default_styles( $GLOBALS['wp_styles'] );
    451451
    452452                $this->assertSame(