Ticket #50662: 50662.diff

src/wp-admin/includes/class-wp-site-health.php

@@ -1735 +1735 @@
         }
 
         /**
+         * Test if plugin an theme auto-updates appear to be configured correctly.
+         *
+         * @since 5.5.0
+         *
+         * @return array The test results.
+         */
+        public function get_test_plugin_theme_auto_updates() {
+                $result = array(
+                        'label'       => __( 'Plugin and Theme auto-updates appear to be configured correctly' ),
+                        'status'      => 'good',
+                        'badge'       => array(
+                                'label' => __( 'Security' ),
+                                'color' => 'blue',
+                        ),
+                        'description' => sprintf(
+                                '<p>%s</p>',
+                                __( 'Plugin and theme auto updates ensure that the latest versions are always installed.' )
+                        ),
+                        'actions'     => '',
+                        'test'        => 'plugin_theme_auto_updates',
+                );
+
+                $check_plugin_theme_updates = $this->detect_plugin_theme_auto_update_issues();
+
+                $result['status'] = $check_plugin_theme_updates->status;
+
+                if ( 'good' !== $check_plugin_theme_updates->status ) {
+                        $result['label'] = __( 'Your site may have problems auto-updating plugins and themes' );
+
+                        $result['description'] .= sprintf(
+                                '<p>%s</p>',
+                                $check_plugin_theme_updates->message
+                        );
+                }
+
+                return $result;
+        }
+
+        /**
          * Test if loopbacks work as expected.
          *
          * A loopback is when WordPress queries itself, for example to start a new WP_Cron instance,
@@ -1969 +2008 @@
         public static function get_tests() {
                 $tests = array(
                         'direct' => array(
-                                'wordpress_version'    => array(
+                                'wordpress_version'         => array(
                                         'label' => __( 'WordPress Version' ),
                                         'test'  => 'wordpress_version',
                                 ),
-                                'plugin_version'       => array(
+                                'plugin_version'            => array(
                                         'label' => __( 'Plugin Versions' ),
                                         'test'  => 'plugin_version',
                                 ),
-                                'theme_version'        => array(
+                                'theme_version'             => array(
                                         'label' => __( 'Theme Versions' ),
                                         'test'  => 'theme_version',
                                 ),
-                                'php_version'          => array(
+                                'php_version'               => array(
                                         'label' => __( 'PHP Version' ),
                                         'test'  => 'php_version',
                                 ),
-                                'php_extensions'       => array(
+                                'php_extensions'            => array(
                                         'label' => __( 'PHP Extensions' ),
                                         'test'  => 'php_extensions',
                                 ),
-                                'php_default_timezone' => array(
+                                'php_default_timezone'      => array(
                                         'label' => __( 'PHP Default Timezone' ),
                                         'test'  => 'php_default_timezone',
                                 ),
-                                'php_sessions'         => array(
+                                'php_sessions'              => array(
                                         'label' => __( 'PHP Sessions' ),
                                         'test'  => 'php_sessions',
                                 ),
-                                'sql_server'           => array(
+                                'sql_server'                => array(
                                         'label' => __( 'Database Server version' ),
                                         'test'  => 'sql_server',
                                 ),
-                                'utf8mb4_support'      => array(
+                                'utf8mb4_support'           => array(
                                         'label' => __( 'MySQL utf8mb4 support' ),
                                         'test'  => 'utf8mb4_support',
                                 ),
-                                'https_status'         => array(
+                                'https_status'              => array(
                                         'label' => __( 'HTTPS status' ),
                                         'test'  => 'https_status',
                                 ),
-                                'ssl_support'          => array(
+                                'ssl_support'               => array(
                                         'label' => __( 'Secure communication' ),
                                         'test'  => 'ssl_support',
                                 ),
-                                'scheduled_events'     => array(
+                                'scheduled_events'          => array(
                                         'label' => __( 'Scheduled events' ),
                                         'test'  => 'scheduled_events',
                                 ),
-                                'http_requests'        => array(
+                                'http_requests'             => array(
                                         'label' => __( 'HTTP Requests' ),
                                         'test'  => 'http_requests',
                                 ),
-                                'debug_enabled'        => array(
+                                'debug_enabled'             => array(
                                         'label' => __( 'Debugging enabled' ),
                                         'test'  => 'is_in_debug_mode',
                                 ),
+                                'plugin_theme_auto_updates' => array(
+                                        'label' => __( 'Plugin & Theme auto-updates' ),
+                                        'test'  => 'plugin_theme_auto_updates',
+                                ),
                         ),
                         'async'  => array(
                                 'dotorg_communication' => array(
@@ -2206 +2249 @@
         }
 
         /**
+         * Check for potential issues with plugin and theme auto-updates.
+         *
+         * Though there is no way to 100% determine if plugin and theme auto-updates are configured
+         * correctly, a few educated guesses could be made to flag any conditions that would
+         * potentially cause unexpected behaviors.
+         *
+         * @since 5.5.0
+         *
+         * @return object The test results.
+         */
+        function detect_plugin_theme_auto_update_issues() {
+                $test_plugins_enabled = apply_filters( 'auto_update_plugin', true );
+                $test_themes_enabled  = apply_filters( 'auto_update_theme', true );
+                $ui_enabled_for_plugins          = wp_is_auto_update_enabled_for_type( 'plugin' );
+                $ui_enabled_for_themes           = wp_is_auto_update_enabled_for_type( 'theme' );
+                $plugin_filter_present           = has_filter( 'auto_update_plugin' );
+                $theme_filter_present            = has_filter( 'auto_update_theme' );
+
+                if ( ( ! $test_plugins_enabled && ! $ui_enabled_for_plugins ) || ( $test_themes_enabled && ! $ui_enabled_for_themes ) ) {
+                        return (object) array(
+                                'status'  => 'critical',
+                                'message' => __( 'Auto-updates for plugins and/or themes appear to be disabled, but settings are still set to be displayed. This could cause auto-updates to not work as expected.' ),
+                        );
+                }
+
+                if ( ( ! $test_plugins_enabled && $plugin_filter_present ) && ( ! $test_themes_enabled && $theme_filter_present ) ) {
+                        return (object) array(
+                                'status'  => 'recommended',
+                                'message' => __( 'Auto-updates for plugins and themes appear to be disabled. This will prevent your sites from receiving new versions automatically when available.' ),
+                        );
+                } elseif ( ! $test_plugins_enabled && $plugin_filter_present ) {
+                        return (object) array(
+                                'status'  => 'recommended',
+                                'message' => __( 'Auto-updates for plugins appear to be disabled. This will prevent your sites from receiving new versions automatically when available.' ),
+                        );
+                } elseif ( ! $test_themes_enabled && $test_themes_enabled ) {
+                        return (object) array(
+                                'status'  => 'recommended',
+                                'message' => __( 'Auto-updates for themes appear to be disabled. This will prevent your sites from receiving new versions automatically when available.' ),
+                        );
+                }
+
+                return (object) array(
+                        'status'  => 'good',
+                        'message' => __( 'There appears to be no issues with plugin and theme auto-updates.' ),
+                );
+        }
+
+        /**
          * Run a loopback test on our site.
          *
          * Loopbacks are what WordPress uses to communicate with itself to start up WP_Cron, scheduled posts,