Context Navigation

Ticket #51124: 51124.3.diff

File 51124.3.diff, 2.3 KB (added by audrasjb, 4 years ago)
Script Loader: Add a `type` parameter to the `wp_add_inline_script` and `wp_add_inline_script` functions.

diff --git a/src/wp-includes/class.wp-scripts.php b/src/wp-includes/class.wp-scripts.php
index 0f38a48618..7f3f1b73e8 100644

  class WP_Scripts extends WP_Dependencies {
          * @param string $data     String containing the JavaScript to be added.
          * @param string $position Optional. Whether to add the inline script
          *                         before the handle or after. Default 'after'.
+         * @param string $type     Optional. Value of the type html attribute. Default empty.
          * @return bool True on success, false on failure.
          */
         public function add_inline_script( $handle, $data, $position = 'after' ) {
+        public function add_inline_script( $handle, $data, $position = 'after', $type = '' ) {
                 if ( ! $data ) {
                         return false;
+                }
-…
+ class WP_Scripts extends WP_Dependencies {
                         $position = 'before';
+                }
+                if ( ! empty ( $type ) ) {
+                        $this->type_attr = " type='" . esc_attr( $type ) . "'";
+                }
                 $script   = (array) $this->get_data( $handle, $position );
                 $script[] = $data;

diff --git a/src/wp-includes/functions.wp-scripts.php b/src/wp-includes/functions.wp-scripts.php
index 82d3685672..a3aa4681b2 100644

  function wp_print_scripts( $handles = false ) {
  * @param string $data     String containing the JavaScript to be added.
  * @param string $position Optional. Whether to add the inline script before the handle
  *                         or after. Default 'after'.
+ * @param string $type     Optional. Value of the type html attribute. Default empty.
  * @return bool True on success, false on failure.
  */
 function wp_add_inline_script( $handle, $data, $position = 'after' ) {
+function wp_add_inline_script( $handle, $data, $position = 'after', $type = '' ) {
         _wp_scripts_maybe_doing_it_wrong( __FUNCTION__, $handle );
         if ( false !== stripos( $data, '</script>' ) ) {
-…
+ function wp_add_inline_script( $handle, $data, $position = 'after' ) {
                 $data = trim( preg_replace( '#<script[^>]*>(.*)</script>#is', '$1', $data ) );
+        }
         return wp_scripts()->add_inline_script( $handle, $data, $position );
+        return wp_scripts()->add_inline_script( $handle, $data, $position, $type );
+}
 /**