Ticket #51299: 51299.1.diff

src/wp-includes/class-walker-nav-menu.php

@@ -106 +106 @@
          *
          * @since 3.0.0
          * @since 4.4.0 The {@see 'nav_menu_item_args'} filter was added.
+         * @since x.x.x Removed redundant title attributes.
          *
          * @see Walker::start_el()
          *
@@ -169 +170 @@
 
                 $output .= $indent . '<li' . $id . $class_names . '>';
 
+                /** This filter is documented in wp-includes/post-template.php */
+                $title = apply_filters( 'the_title', $item->title, $item->ID );
+
+                /**
+                 * Filters a menu item's title.
+                 *
+                 * @since 4.4.0
+                 *
+                 * @param string   $title The menu item's title.
+                 * @param WP_Post  $item  The current menu item.
+                 * @param stdClass $args  An object of wp_nav_menu() arguments.
+                 * @param int      $depth Depth of menu item. Used for padding.
+                 */
+                $title = apply_filters( 'nav_menu_item_title', $title, $item, $args, $depth );
+
                 $atts           = array();
                 $atts['title']  = ! empty( $item->attr_title ) ? $item->attr_title : '';
                 $atts['target'] = ! empty( $item->target ) ? $item->target : '';
@@ -201 +217 @@
                  */
                 $atts = apply_filters( 'nav_menu_link_attributes', $atts, $item, $args, $depth );
 
+                // Remove redundant title attributes.
+                if ( trim( strtolower( $atts['title'] ) ) == trim( strtolower( $title ) ) ) {
+                        $atts['title'] = '';
+                }
+
                 $attributes = '';
                 foreach ( $atts as $attr => $value ) {
                         if ( is_scalar( $value ) && '' !== $value && false !== $value ) {
@@ -209 +230 @@
                         }
                 }
 
-                /** This filter is documented in wp-includes/post-template.php */
-                $title = apply_filters( 'the_title', $item->title, $item->ID );
-
-                /**
-                 * Filters a menu item's title.
-                 *
-                 * @since 4.4.0
-                 *
-                 * @param string   $title The menu item's title.
-                 * @param WP_Post  $item  The current menu item.
-                 * @param stdClass $args  An object of wp_nav_menu() arguments.
-                 * @param int      $depth Depth of menu item. Used for padding.
-                 */
-                $title = apply_filters( 'nav_menu_item_title', $title, $item, $args, $depth );
-
                 $item_output  = $args->before;
                 $item_output .= '<a' . $attributes . '>';
                 $item_output .= $args->link_before . $title . $args->link_after;