Ticket #51390: 51390.4.diff

src/wp-includes/theme.php

@@ -2475 +2475 @@
  *              by adding it to the function signature.
  * @since 5.5.0 The `core-block-patterns` feature was added and is enabled by default.
  * @since 5.5.0 The `custom-logo` feature now also accepts 'unlink-homepage-logo'.
+ * @since 5.6.0 The `post-formats` feature now returns doing it wrong if no array is passed
  *
  * @global array $_wp_theme_features
  *
@@ -2517 +2518 @@
                                 unset( $post_formats['standard'] );
 
                                 $args[0] = array_intersect( $args[0], array_keys( $post_formats ) );
+                        } else {
+                                _doing_it_wrong( "add_theme_support( 'post-formats' )", __( 'You need to pass an array of types.' ), '5.6.0' );
+                                return false;
                         }
                         break;
 

tests/phpunit/tests/post/formats.php

@@ -8 +8 @@
                 parent::setUp();
         }
 
+        /**
+         * @ticket 51390
+         */
+        function test_post_format_doing_it_wrong() {
+                $this->setExpectedIncorrectUsage( "add_theme_support( 'post-formats' )" );
+
+                // The second parameter should be an array.
+                $this->assertFalse( add_theme_support( 'post-formats' ) );
+        }
+
         function test_set_get_post_format_for_post() {
                 $post_id = self::factory()->post->create();