Ticket #51553: WP_ListTable-column_width.diff

src/wp-admin/includes/class-wp-comments-list-table.php

@@ -1047 +1047 @@
         }
 
         /**
-         * @param WP_Comment $comment     The comment object.
+         * @since 5.9.0 Renamed `$comment` to `$item` to match parent class for PHP 8 named param.
+         *
+         * @param WP_Comment $item        The comment object.
          * @param string     $column_name The custom column's name.
          */
-        public function column_default( $comment, $column_name ) {
+        public function column_default( $item, $column_name ) {
                 /**
                  * Fires when the default column output is displayed for a single row.
                  *
@@ -1059 +1061 @@
                  * @param string $column_name The custom column's name.
                  * @param int    $comment_id  The custom column's unique ID number.
                  */
-                do_action( 'manage_comments_custom_column', $column_name, $comment->comment_ID );
+                do_action( 'manage_comments_custom_column', $column_name, $item->comment_ID );
         }
 }

src/wp-admin/includes/class-wp-links-list-table.php

@@ -279 +279 @@
          * Handles the default column output.
          *
          * @since 4.3.0
+         * @since 5.9.0 Renamed `$link` to `$item` to match parent class for PHP 8 named param.
          *
-         * @param object $link        Link object.
+         * @param object $item        Link object.
          * @param string $column_name Current column name.
          */
-        public function column_default( $link, $column_name ) {
+        public function column_default( $item, $column_name ) {
                 /**
                  * Fires for each registered custom link column.
                  *
@@ -292 +293 @@
                  * @param string $column_name Name of the custom column.
                  * @param int    $link_id     Link ID.
                  */
-                do_action( 'manage_link_custom_column', $column_name, $link->link_id );
+                do_action( 'manage_link_custom_column', $column_name, $item->link_id );
         }
 
         public function display_rows() {

src/wp-admin/includes/class-wp-media-list-table.php

@@ -594 +594 @@
          * Handles output for the default column.
          *
          * @since 4.3.0
+         * @since 5.9.0 Renamed `$post` to `$item` to match parent class for PHP 8 named param.
          *
-         * @param WP_Post $post        The current WP_Post object.
+         * @param WP_Post $item        The current WP_Post object.
          * @param string  $column_name Current column name.
          */
-        public function column_default( $post, $column_name ) {
+        public function column_default( $item, $column_name ) {
+                // Restores the more descriptive, specific name for use within this method.
+                $post = $item;
+
                 if ( 'categories' === $column_name ) {
                         $taxonomy = 'category';
                 } elseif ( 'tags' === $column_name ) {

src/wp-admin/includes/class-wp-ms-sites-list-table.php

@@ -560 +560 @@
          * Handles output for the default column.
          *
          * @since 4.3.0
+         * @since 5.9.0 Renamed `$blog` to `$item` to match parent class for PHP 8 named param.
          *
-         * @param array  $blog        Current site.
+         * @param array  $item        Current site.
          * @param string $column_name Current column name.
          */
-        public function column_default( $blog, $column_name ) {
+        public function column_default( $item, $column_name ) {
                 /**
                  * Fires for each registered custom column in the Sites list table.
                  *
@@ -573 +574 @@
                  * @param string $column_name The name of the column to display.
                  * @param int    $blog_id     The site ID.
                  */
-                do_action( 'manage_sites_custom_column', $column_name, $blog['blog_id'] );
+                do_action( 'manage_sites_custom_column', $column_name, $item['blog_id'] );
         }
 
         /**

src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -855 +855 @@
          * Handles default column output.
          *
          * @since 4.3.0
+         * @since 5.9.0 Renamed `$theme` to `$item` to match parent class for PHP 8 named param.
          *
-         * @param WP_Theme $theme       The current WP_Theme object.
+         * @param WP_Theme $item        The current WP_Theme object.
          * @param string   $column_name The current column name.
          */
-        public function column_default( $theme, $column_name ) {
-                $stylesheet = $theme->get_stylesheet();
-
+        public function column_default( $item, $column_name ) {
                 /**
                  * Fires inside each custom column of the Multisite themes list table.
                  *
@@ -871 +870 @@
                  * @param string   $stylesheet  Directory name of the theme.
                  * @param WP_Theme $theme       Current WP_Theme object.
                  */
-                do_action( 'manage_themes_custom_column', $column_name, $stylesheet, $theme );
+                do_action(
+                        'manage_themes_custom_column',
+                        $column_name,
+                        $item->get_stylesheet(), // Directory name of the theme.
+                        $item // Theme object.
+                );
         }
 
         /**

src/wp-admin/includes/class-wp-ms-users-list-table.php

@@ -442 +442 @@
          * Handles the default column output.
          *
          * @since 4.3.0
+         * @since 5.9.0 Renamed `$user` to `$item` to match parent class for PHP 8 named param.
          *
-         * @param WP_User $user        The current WP_User object.
+         * @param WP_User $item        The current WP_User object.
          * @param string  $column_name The current column name.
          */
-        public function column_default( $user, $column_name ) {
+        public function column_default( $item, $column_name ) {
                 /** This filter is documented in wp-admin/includes/class-wp-users-list-table.php */
-                echo apply_filters( 'manage_users_custom_column', '', $column_name, $user->ID );
+                echo apply_filters(
+                        'manage_users_custom_column',
+                        '', // Custom column output. Default empty.
+                        $column_name,
+                        $item->ID // User ID.
+                );
         }
 
         public function display_rows() {

src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1235 +1235 @@
          * Handles the default column output.
          *
          * @since 4.3.0
+         * @since 5.9.0 Renamed `$post` to `$item` to match parent class for PHP 8 named param.
          *
-         * @param WP_Post $post        The current WP_Post object.
+         * @param WP_Post $item        The current WP_Post object.
          * @param string  $column_name The current column name.
          */
-        public function column_default( $post, $column_name ) {
+        public function column_default( $item, $column_name ) {
+                // Restores the more descriptive, specific name for use within this method.
+                $post = $item;
+
                 if ( 'categories' === $column_name ) {
                         $taxonomy = 'category';
                 } elseif ( 'tags' === $column_name ) {

src/wp-admin/includes/class-wp-terms-list-table.php

@@ -620 +620 @@
         }
 
         /**
-         * @param WP_Term $tag         Term object.
+         * @since 5.9.0 Renamed `$tag` to `$item` to match parent class for PHP 8 named param.
+         *
+         * @param WP_Term $item        Term object.
          * @param string  $column_name Name of the column.
          * @return string
          */
-        public function column_default( $tag, $column_name ) {
+        public function column_default( $item, $column_name ) {
                 /**
                  * Filters the displayed columns in the terms list table.
                  *
@@ -638 +640 @@
                  *
                  * @since 2.8.0
                  *
-                 * @param string $string      Blank string.
+                 * @param string $string      Custom column output. Default empty.
                  * @param string $column_name Name of the column.
                  * @param int    $term_id     Term ID.
                  */
-                return apply_filters( "manage_{$this->screen->taxonomy}_custom_column", '', $column_name, $tag->term_id );
+                return apply_filters( "manage_{$this->screen->taxonomy}_custom_column", '', $column_name, $item->term_id );
         }
 
         /**