Ticket #5249: 5249b.diff

wp-includes/js/wp-lists.js

@@ -282 +282 @@
                 }
 
                 if ( 'none' != s.addColor ) {
+                        var b = e.css( 'background-color' );
+                        if ( b == 'transparent' ) { b = ''; }
                         Fat.fade_element(e.attr('id'),null,700,s.addColor);
                         setTimeout( function() {
-                                var b = e.css( 'background-color' );
                                 var g = e.css( 'background-color', '' ).css( 'background-color' );
                                 if ( b != g ) { e.css( 'background-color', b ); }
                         }, 705 );

wp-includes/script-loader.php

@@ -61 +61 @@
                         'delText' => __('Are you sure you want to delete this %thing%?')
                 ) );
 
-                $this->add( 'wp-lists', '/wp-includes/js/wp-lists.js', array('jquery'), '20070823' );
+                $this->add( 'wp-lists', '/wp-includes/js/wp-lists.js', array('jquery'), '20071023' );
                 $this->localize( 'wp-lists', 'wpListL10n', array(
                         'url' => get_option( 'siteurl' ) . '/wp-admin/admin-ajax.php'
                 ) );
@@ -118 +118 @@
                         $this->add( 'admin-categories', '/wp-admin/js/categories.js', array('wp-lists'), '20070823' );
                         $this->add( 'admin-custom-fields', '/wp-admin/js/custom-fields.js', array('wp-lists'), '20070823' );
                         $this->add( 'admin-comments', '/wp-admin/js/edit-comments.js', array('wp-lists'), '20070822' );
-                        $this->add( 'admin-posts', '/wp-admin/js/edit-posts.js', array('wp-lists'), '20070823' );
+                        $this->add( 'admin-posts', '/wp-admin/js/edit-posts.js', array('wp-lists'), '20071023' );
                         $this->add( 'admin-users', '/wp-admin/js/users.js', array('wp-lists'), '20070823' );
                         $this->add( 'xfn', '/wp-admin/js/xfn.js', false, '3517' );
                         $this->add( 'upload', '/wp-admin/js/upload.js', array('jquery'), '20070518' );

wp-admin/admin-ajax.php

@@ -15 +15 @@
 case 'add-post' :
         check_ajax_referer( 'add-post' );
         add_filter( 'post_limits', $limit_filter = create_function( '$a', '$b = split(" ",$a); if ( !isset($b[2]) ) return $a; $start = intval(trim($b[1])) / 20 * 15; if ( !is_int($start) ) return $a; $start += intval(trim($b[2])) - 1; return "LIMIT $start, 1";' ) );
-        wp_edit_posts_query( '_POST' );
+        wp_edit_posts_query( $_POST );
+        if ( !have_posts() )
+                die('1');
         $posts_columns = wp_manage_posts_columns();
         ob_start();
                 include( 'edit-post-rows.php' );

wp-admin/includes/post.php

@@ -476 +476 @@
         return $wpdb->query( "UPDATE $wpdb->posts SET post_parent = $new_ID WHERE post_parent = $old_ID" );
 }
 
-function wp_edit_posts_query( $q = '_GET' ) {
+function wp_edit_posts_query( $q = false ) {
         global $wpdb;
-        $$q['m']   = (int) $$q['m'];
-        $$q['cat'] = (int) $$q['cat'];
+        if ( false === $q )
+                $q = $_GET;
+        $q['m']   = (int) $q['m'];
+        $q['cat'] = (int) $q['cat'];
         $post_stati  = array(   //      array( adj, noun )
                                 'draft' => array(__('Draft'), _c('Drafts|manage posts header')),
                                 'future' => array(__('Scheduled'), __('Scheduled posts')),
@@ -492 +494 @@
 
         $post_status_q = '';
         $post_status_label = _c('Posts|manage posts header');
-        if ( isset($$q['post_status']) && in_array( $$q['post_status'], array_keys($post_stati) ) ) {
-                $post_status_label = $post_stati[$$q['post_status']][1];
-                $post_status_q = '&post_status=' . $$q['post_status'];
+        if ( isset($q['post_status']) && in_array( $q['post_status'], array_keys($post_stati) ) ) {
+                $post_status_label = $post_stati[$q['post_status']][1];
+                $post_status_q = '&post_status=' . $q['post_status'];
         }
 
-        if ( 'pending' === $$q['post_status'] ) {
+        if ( 'pending' === $q['post_status'] ) {
                 $order = 'ASC';
                 $orderby = 'modified';
-        } elseif ( 'draft' === $$q['post_status'] ) {
+        } elseif ( 'draft' === $q['post_status'] ) {
                 $order = 'DESC';
                 $orderby = 'modified';
         } else {

wp-admin/js/edit-posts.js

@@ -6 +6 @@
 else
         delAfter = function() {
                 list[0].wpList.add( extra.children(':eq(0)').remove().clone() );
-                $('#get-extra-button').click();
+                $('#get-extra-posts').submit();
         }
 
 var addBefore = function ( settings ) {

wp-admin/edit.php

@@ -108 +108 @@
                 <?php wp_dropdown_categories('show_option_all='.__('All').'&hide_empty=1&hierarchical=1&show_count=1&selected='.$cat);?>
         </fieldset>
         <input type="submit" id="post-query-submit" value="<?php _e('Filter &#187;'); ?>" class="button" />
-        <?php wp_nonce_field( 'add-post', '_ajax_nonce', false ); ?>
-        <input type="button" id="get-extra-button" class="add:the-extra-list:searchform" style="display:none" />
 </form>
 
 <?php do_action('restrict_manage_posts'); ?>
@@ -118 +116 @@
 
 <?php include( 'edit-post-rows.php' ); ?>
 
+<form action="" method="post" id="get-extra-posts" class="add:the-extra-list:" style="display:none">
+        <?php wp_nonce_field( 'add-post', '_ajax_nonce', false ); ?>
+</form>
+
 <div id="ajax-response"></div>
 
 <div class="navigation">