Ticket #52592: 52592-tests.diff

tests/phpunit/tests/blocks/wpBlockStylesRegistry.php

@@ -47 +47 @@
          */
         public function test_register_block_style_with_string_block_name() {
                 $name             = 'core/paragraph';
-                $style_properties = array( 'name' => 'fancy' );
+                $style_properties = array(
+                        'name'  => 'fancy',
+                        'label' => 'Fancy',
+                );
                 $result           = $this->registry->register( $name, $style_properties );
                 $this->assertTrue( $result );
                 $this->assertTrue( $this->registry->is_registered( 'core/paragraph', 'fancy' ) );
@@ -60 +63 @@
          */
         public function test_register_block_style_with_array_of_block_names() {
                 $names            = array( 'core/paragraph', 'core/group' );
-                $style_properties = array( 'name' => 'plain' );
+                $style_properties = array(
+                        'name'  => 'plain',
+                        'label' => 'Plain',
+                );
                 $result           = $this->registry->register( $names, $style_properties );
                 $this->assertTrue( $result );
                 $this->assertTrue( $this->registry->is_registered( 'core/paragraph', 'plain' ) );
                 $this->assertTrue( $this->registry->is_registered( 'core/group', 'plain' ) );
         }
+
+        /**
+         * Should accept valid string style label.
+         * The registered style should have the same label.
+         *
+         * @ticket 52592
+         *
+         * @covers WP_Block_Styles_Registry::register
+         * @covers WP_Block_Styles_Registry::is_registered
+         * @covers WP_Block_Styles_Registry::get_registered_styles_for_block
+         */
+        public function test_register_block_style_with_string_style_label() {
+                $name             = 'core/paragraph';
+                $style_properties = array(
+                        'name'  => 'fancy',
+                        'label' => 'Fancy',
+                );
+                $result           = $this->registry->register( $name, $style_properties );
+
+                $this->assertTrue( $result, 'The block style should be registered when the label is a valid string.' );
+                $this->assertTrue(
+                        $this->registry->is_registered( $name, 'fancy' ),
+                        'The block type should have the block style registered when the label is valid.'
+                );
+                $this->assertEquals(
+                        $style_properties['label'],
+                        $this->registry->get_registered_styles_for_block( $name )['fancy']['label'],
+                        'The registered block style should have the same label.'
+                );
+        }
+
+        /**
+         * Should not accept invalid style label.
+         *
+         * @ticket 52592
+         *
+         * @covers WP_Block_Styles_Registry::register
+         * @covers WP_Block_Styles_Registry::is_registered
+         */
+        public function test_register_block_style_with_invalid_style_label() {
+                $name             = 'core/paragraph';
+                $style_properties = array(
+                        'name' => 'fancy',
+                );
+
+                $this->setExpectedIncorrectUsage( 'WP_Block_Styles_Registry::register' );
+
+                $result           = $this->registry->register( $name, $style_properties );
+                $this->assertFalse( $result, 'The block style should not be registered when the label property is missing.' );
+                $this->assertFalse(
+                        $this->registry->is_registered( $name, 'fancy' ),
+                        'The block type should not have the block style registered when the label property is missing.'
+                );
+
+                $style_properties['label'] = ['Fancy'];
+
+                $result           = $this->registry->register( $name, $style_properties );
+                $this->assertFalse( $result, 'The block style should not be registered when the label property is not a string.' );
+                $this->assertFalse(
+                        $this->registry->is_registered( $name, 'fancy' ),
+                        'The block type should not have the block style registered when the label property is not a string.'
+                );
+        }
 }