Ticket #52710: 52710.diff

src/wp-includes/class-wp-term-query.php

@@ -88 +88 @@
          * @since 4.6.0 Introduced 'term_taxonomy_id' parameter.
          * @since 4.7.0 Introduced 'object_ids' parameter.
          * @since 4.9.0 Added 'slug__in' support for 'orderby'.
+         * @since 5.x.0 Introduced 'update_get_terms_cache' parameter.
          *
          * @param string|array $query {
          *     Optional. Array or query string of term query parameters. Default empty.
@@ -174 +175 @@
          *                                                Default false.
          *     @type string       $cache_domain           Unique cache key to be produced when this query is stored in
          *                                                an object cache. Default is 'core'.
+         *     @type bool         $update_get_terms_cache Whether to cache the query results. Default true.
          *     @type bool         $update_term_meta_cache Whether to prime meta caches for matched terms. Default true.
          *     @type array        $meta_query             Optional. Meta query clauses to limit retrieved terms by.
          *                                                See `WP_Meta_Query`. Default empty.
@@ -213 +215 @@
                         'parent'                 => '',
                         'childless'              => false,
                         'cache_domain'           => 'core',
+                        'update_get_terms_cache' => true,
                         'update_term_meta_cache' => true,
                         'meta_query'             => '',
                         'meta_key'               => '',
@@ -736 +739 @@
                         return $this->terms;
                 }
 
-                // $args can be anything. Only use the args defined in defaults to compute the key.
-                $key          = md5( serialize( wp_array_slice_assoc( $args, array_keys( $this->query_var_defaults ) ) ) . serialize( $taxonomies ) . $this->request );
-                $last_changed = wp_cache_get_last_changed( 'terms' );
-                $cache_key    = "get_terms:$key:$last_changed";
-                $cache        = wp_cache_get( $cache_key, 'terms' );
+                $cache_key = false;
+
+                if ( ! empty( $args['update_get_terms_cache'] ) ) {
+                        // $args can be anything. Only use the args defined in defaults to compute the key.
+                        $key          = md5( serialize( wp_array_slice_assoc( $args, array_keys( $this->query_var_defaults ) ) ) . serialize( $taxonomies ) . $this->request );
+                        $last_changed = wp_cache_get_last_changed( 'terms' );
+                        $cache_key    = "get_terms:$key:$last_changed";
+                }
+
+                $cache = $cache_key ? wp_cache_get( $cache_key, 'terms' ) : false;
                 if ( false !== $cache ) {
                         if ( 'all' === $_fields || 'all_with_object_id' === $_fields ) {
                                 $cache = $this->populate_terms( $cache );
@@ -752 +760 @@
 
                 if ( 'count' === $_fields ) {
                         $count = $wpdb->get_var( $this->request );
-                        wp_cache_set( $cache_key, $count, 'terms' );
+                        if ( $cache_key ) {
+                                wp_cache_set( $cache_key, $count, 'terms' );
+                        }
                         return $count;
                 }
 
@@ -769 +779 @@
                 }
 
                 if ( empty( $terms ) ) {
-                        wp_cache_add( $cache_key, array(), 'terms', DAY_IN_SECONDS );
+                        if ( $cache_key ) {
+                                wp_cache_add( $cache_key, array(), 'terms', DAY_IN_SECONDS );
+                        }
                         return array();
                 }
 
@@ -874 +886 @@
                         }
                 }
 
-                wp_cache_add( $cache_key, $terms, 'terms', DAY_IN_SECONDS );
+                if ( $cache_key ) {
+                        wp_cache_add( $cache_key, $terms, 'terms', DAY_IN_SECONDS );
+                }
 
                 if ( 'all' === $_fields || 'all_with_object_id' === $_fields ) {
                         $terms = $this->populate_terms( $terms );

tests/phpunit/tests/term/getTerms.php

@@ -194 +194 @@
                 // @todo Repeat with term insert and update.
         }
 
+        /**
+         * @ticket 52710
+         */
+        public function test_get_terms_without_update_get_terms_cache() {
+                global $wpdb;
+
+                $this->set_up_three_posts_and_tags();
+
+                $num_queries = $wpdb->num_queries;
+
+                // last_changed and num_queries should bump.
+                $terms = get_terms(
+                        'post_tag',
+                        array(
+                                'update_get_terms_cache' => false,
+                                'update_term_meta_cache' => false,
+                        )
+                );
+                $this->assertSame( 3, count( $terms ) );
+                $this->assertEmpty( wp_cache_get( 'last_changed', 'terms' ) );
+                $this->assertSame( $num_queries + 1, $wpdb->num_queries );
+
+                $num_queries = $wpdb->num_queries;
+
+                // last_changed and num_queries should bump again.
+                $terms = get_terms(
+                        'post_tag',
+                        array(
+                                'update_get_terms_cache' => false,
+                                'update_term_meta_cache' => false,
+                        )
+                );
+                $this->assertSame( 3, count( $terms ) );
+                $this->assertEmpty( wp_cache_get( 'last_changed', 'terms' ) );
+                $this->assertSame( $num_queries + 1, $wpdb->num_queries );
+        }
+
         /**
          * @ticket 23506
          */