WordPress.org
Get WordPress

Make WordPress Core

Ticket #52826: 52826.2.diff

File 52826.2.diff, 1.3 KB (added by Mista-Flo, 5 years ago)

Properly fix the issue with good type hint

  • src/wp-includes/media.php 

    diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php
index b0e2c79aef..418fa666e3 100644
    a b function wp_show_heic_upload_error( $plupload_settings ) { 
    49764976 * @since 5.7.0
    49774977 *
    49784978 * @param string $filename  The file path.
    4979  * @param array  $imageinfo Extended image information, passed by reference.
     4979 * @param array  &$image_info [optional] Extended image information, passed by reference.
    49804980 * @return array|false Array of image information or false on failure.
    49814981 */
    4982 function wp_getimagesize( $filename, &$imageinfo = array() ) {
     4982function wp_getimagesize( $filename, array &$image_info = null ) {
    49834983        if (
    49844984                // Skip when running unit tests.
    49854985                ! defined( 'WP_RUN_CORE_TESTS' )
    … … function wp_getimagesize( $filename, &$imageinfo = array() ) { 
    49874987                // Return without silencing errors when in debug mode.
    49884988                defined( 'WP_DEBUG' ) && WP_DEBUG
    49894989        ) {
    4990                 return getimagesize( $filename, $imageinfo );
     4990                return getimagesize( $filename, $image_info );
    49914991        }
    49924992
    49934993        /*
    … … function wp_getimagesize( $filename, &$imageinfo = array() ) { 
    50015001         *
    50025002         * phpcs:ignore WordPress.PHP.NoSilencedErrors
    50035003         */
    5004         return @getimagesize( $filename, $imageinfo );
     5004        return @getimagesize( $filename, $image_info );
    50055005}