Ticket #54728: 54728.2.diff

src/wp-admin/includes/misc.php

@@ -597 +597 @@
                         continue;
                 }
 
-                if ( T_STRING == $tokens[ $t ][0] && ( '(' === $tokens[ $t + 1 ] || '(' === $tokens[ $t + 2 ] ) ) {
+                if ( T_STRING === $tokens[ $t ][0] && ( '(' === $tokens[ $t + 1 ] || '(' === $tokens[ $t + 2 ] ) ) {
                         // If it's a function or class defined locally, there's not going to be any docs available.
                         if ( ( isset( $tokens[ $t - 2 ][1] ) && in_array( $tokens[ $t - 2 ][1], array( 'function', 'class' ), true ) )
-                                || ( isset( $tokens[ $t - 2 ][0] ) && T_OBJECT_OPERATOR == $tokens[ $t - 1 ][0] )
+                                || ( isset( $tokens[ $t - 2 ][0] ) && T_OBJECT_OPERATOR === $tokens[ $t - 1 ][0] )
                         ) {
                                 $ignore_functions[] = $tokens[ $t ][1];
                         }
@@ -651 +651 @@
                 $option = $_POST['wp_screen_options']['option'];
                 $value  = $_POST['wp_screen_options']['value'];
 
-                if ( sanitize_key( $option ) != $option ) {
+                if ( sanitize_key( $option ) !== $option ) {
                         return;
                 }
 
@@ -771 +771 @@
         }
         $xpath = new DOMXPath( $doc );
         $rules = $xpath->query( '/configuration/system.webServer/rewrite/rules/rule[starts-with(@name,\'wordpress\')] | /configuration/system.webServer/rewrite/rules/rule[starts-with(@name,\'WordPress\')]' );
-        if ( 0 == $rules->length ) {
+        if ( 0 === $rules->length ) {
                 return false;
         } else {
                 return true;
@@ -867 +867 @@
 
                         $xmlnodes = $xpath->query( '/configuration/system.webServer' );
                         if ( $xmlnodes->length > 0 ) {
-                                $system_webServer_node = $xmlnodes->item( 0 );
-                                $system_webServer_node->appendChild( $rewrite_node );
+                                $system_web_server_node = $xmlnodes->item( 0 );
+                                $system_web_server_node->appendChild( $rewrite_node );
                         } else {
-                                $system_webServer_node = $doc->createElement( 'system.webServer' );
-                                $system_webServer_node->appendChild( $rewrite_node );
+                                $system_web_server_node = $doc->createElement( 'system.webServer' );
+                                $system_web_server_node->appendChild( $rewrite_node );
 
                                 $xmlnodes = $xpath->query( '/configuration' );
                                 if ( $xmlnodes->length > 0 ) {
                                         $config_node = $xmlnodes->item( 0 );
-                                        $config_node->appendChild( $system_webServer_node );
+                                        $config_node->appendChild( $system_web_server_node );
                                 } else {
                                         $config_node = $doc->createElement( 'configuration' );
                                         $doc->appendChild( $config_node );
-                                        $config_node->appendChild( $system_webServer_node );
+                                        $config_node->appendChild( $system_web_server_node );
                                 }
                         }
                 }
@@ -955 +955 @@
                 foreach ( $_wp_admin_css_colors as $color => $color_info ) :
 
                         ?>
-                        <div class="color-option <?php echo ( $color == $current_color ) ? 'selected' : ''; ?>">
+                        <div class="color-option <?php echo ( $color === $current_color ) ? 'selected' : ''; ?>">
                                 <input name="admin_color" id="admin_color_<?php echo esc_attr( $color ); ?>" type="radio" value="<?php echo esc_attr( $color ); ?>" class="tog" <?php checked( $color, $current_color ); ?> />
                                 <input type="hidden" class="css_url" value="<?php echo esc_url( $color_info->url ); ?>" />
                                 <input type="hidden" class="icon_colors" value="<?php echo esc_attr( wp_json_encode( array( 'icons' => $color_info->icon_colors ) ) ); ?>" />