Ticket #55069: 0002-class-wp-filesystem-direct-remove-unnecessary-is_dir.2.patch

src/wp-admin/includes/class-wp-filesystem-direct.php

@@ -606 +606 @@
                         $limit_file = false;
                 }
 
-                if ( ! $this->is_dir( $path ) || ! $this->is_readable( $path ) ) {
-                        return false;
-                }
+                /*
+                 * Silencing notice and warning is intentional to avoid extra system calls.
+                 * See https://core.trac.wordpress.org/ticket/55069
+                 */
+                $dir = @dir( $path ); // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
 
-                $dir = dir( $path );
-
                 if ( ! $dir ) {
                         return false;
                 }

src/wp-admin/includes/class-wp-filesystem-ssh2.php

@@ -756 +756 @@
                         $limit_file = false;
                 }
 
-                if ( ! $this->is_dir( $path ) || ! $this->is_readable( $path ) ) {
+                /*
+                 * Silencing notice and warning is intentional to avoid extra system calls.
+                 * See https://core.trac.wordpress.org/ticket/55069
+                 */
+                $dir = @dir( $this->sftp_path( $path ) ); // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
+
+                if ( ! $dir ) {
                         return false;
                 }
 
                 $ret = array();
-                $dir = dir( $this->sftp_path( $path ) );
 
-                if ( ! $dir ) {
-                        return false;
-                }
-
                 while ( false !== ( $entry = $dir->read() ) ) {
                         $struc         = array();
                         $struc['name'] = $entry;