Make WordPress Core

Ticket #55555: 55555.diff

File 55555.diff, 1.6 KB (added by sabernhardt, 2 years ago)

splitting span elements so the one with an icon can have aria-hidden

  • src/wp-admin/includes/class-wp-media-list-table.php

     
    351351                if ( ! $this->detached ) {
    352352                        $posts_columns['parent'] = _x( 'Uploaded to', 'column name' );
    353353                        if ( post_type_supports( 'attachment', 'comments' ) ) {
    354                                 $posts_columns['comments'] = '<span class="vers comment-grey-bubble" title="' . esc_attr__( 'Comments' ) . '"><span class="screen-reader-text">' . __( 'Comments' ) . '</span></span>';
     354                                $posts_columns['comments'] = '<span class="vers comment-grey-bubble" title="' . esc_attr__( 'Comments' ) . '" aria-hidden="true"></span><span class="screen-reader-text">' . __( 'Comments' ) . '</span>';
    355355                        }
    356356                }
    357357
  • src/wp-admin/includes/class-wp-posts-list-table.php

     
    691691                        && ! in_array( $post_status, array( 'pending', 'draft', 'future' ), true )
    692692                ) {
    693693                        $posts_columns['comments'] = sprintf(
    694                                 '<span class="vers comment-grey-bubble" title="%1$s"><span class="screen-reader-text">%2$s</span></span>',
     694                                '<span class="vers comment-grey-bubble" title="%1$s" aria-hidden="true"></span><span class="screen-reader-text">%2$s</span>',
    695695                                esc_attr__( 'Comments' ),
    696696                                __( 'Comments' )
    697697                        );