Ticket #56007: 56007.diff

src/wp-admin/plugin-editor.php

@@ -167 +167 @@
 
         if ( ! empty( $functions ) ) {
                 $docs_select  = '<select name="docs-list" id="docs-list">';
-                $docs_select .= '<option value="">' . __( 'Function Name&hellip;' ) . '</option>';
+                $docs_select .= '<option value="">' . esc_html__( 'Function Name&hellip;' ) . '</option>';
+
                 foreach ( $functions as $function ) {
                         $docs_select .= '<option value="' . esc_attr( $function ) . '">' . esc_html( $function ) . '()</option>';
                 }
+
                 $docs_select .= '</select>';
         }
 }

src/wp-admin/theme-editor.php

@@ -164 +164 @@
         if ( '.php' === substr( $file, strrpos( $file, '.' ) ) ) {
                 $functions = wp_doc_link_parse( $content );
 
-                $docs_select  = '<select name="docs-list" id="docs-list">';
-                $docs_select .= '<option value="">' . esc_attr__( 'Function Name&hellip;' ) . '</option>';
-                foreach ( $functions as $function ) {
-                        $docs_select .= '<option value="' . esc_attr( urlencode( $function ) ) . '">' . htmlspecialchars( $function ) . '()</option>';
+                if ( ! empty( $functions ) ) {
+                        $docs_select  = '<select name="docs-list" id="docs-list">';
+                        $docs_select .= '<option value="">' . esc_html__( 'Function Name&hellip;' ) . '</option>';
+
+                        foreach ( $functions as $function ) {
+                                $docs_select .= '<option value="' . esc_attr( $function ) . '">' . esc_html( $function ) . '()</option>';
+                        }
+
+                        $docs_select .= '</select>';
                 }
-                $docs_select .= '</select>';
         }
 
         $content = esc_textarea( $content );