Ticket #57393: 57393.patch

wp-admin/includes/user.php

@@ -132 +132 @@
         }
 
         if ( $update ) {
-                $user->rich_editing         = isset( $_POST['rich_editing'] ) && 'false' === $_POST['rich_editing'] ? 'false' : 'true';
-                $user->syntax_highlighting  = isset( $_POST['syntax_highlighting'] ) && 'false' === $_POST['syntax_highlighting'] ? 'false' : 'true';
+                $user->rich_editing         = isset( $_POST['rich_editing'] ) ? 'true' : 'false';
+                $user->syntax_highlighting  = isset( $_POST['syntax_highlighting'] ) ? 'true' : 'false';
                 $user->admin_color          = isset( $_POST['admin_color'] ) ? sanitize_text_field( $_POST['admin_color'] ) : 'fresh';
                 $user->show_admin_bar_front = isset( $_POST['admin_bar_front'] ) ? 'true' : 'false';
         }

wp-admin/user-edit.php

@@ -272 +272 @@
                                                 <tr class="user-rich-editing-wrap">
                                                         <th scope="row"><?php _e( 'Visual Editor' ); ?></th>
                                                         <td>
-                                                                <label for="rich_editing"><input name="rich_editing" type="checkbox" id="rich_editing" value="false" <?php checked( 'false', $profile_user->rich_editing ); ?> />
-                                                                        <?php _e( 'Disable the visual editor when writing' ); ?>
+                                                                <label for="rich_editing"><input name="rich_editing" type="checkbox" id="rich_editing" value="true"<?php checked( 'true', $profile_user->rich_editing ); ?> />
+                                                                        <?php _e( 'Enable the visual editor when writing' ); ?>
                                                                 </label>
                                                         </td>
                                                 </tr>
@@ -296 +296 @@
                                         <tr class="user-syntax-highlighting-wrap">
                                                 <th scope="row"><?php _e( 'Syntax Highlighting' ); ?></th>
                                                 <td>
-                                                        <label for="syntax_highlighting"><input name="syntax_highlighting" type="checkbox" id="syntax_highlighting" value="false" <?php checked( 'false', $profile_user->syntax_highlighting ); ?> />
-                                                                <?php _e( 'Disable syntax highlighting when editing code' ); ?>
+                                                        <label for="syntax_highlighting"><input name="syntax_highlighting" type="checkbox" id="syntax_highlighting" value="true"<?php checked( 'true', $profile_user->syntax_highlighting ); ?> />
+                                                                <?php _e( 'Enable syntax highlighting when editing code' ); ?>
                                                         </label>
                                                 </td>
                                         </tr>
@@ -342 +342 @@
                                                 <th scope="row"><?php _e( 'Toolbar' ); ?></th>
                                                 <td>
                                                         <label for="admin_bar_front">
-                                                                <input name="admin_bar_front" type="checkbox" id="admin_bar_front" value="1"<?php checked( _get_admin_bar_pref( 'front', $profile_user->ID ) ); ?> />
+                                                                <input name="admin_bar_front" type="checkbox" id="admin_bar_front" value="true"<?php checked( _get_admin_bar_pref( 'front', $profile_user->ID ) ); ?> />
                                                                 <?php _e( 'Show Toolbar when viewing site' ); ?>
                                                         </label><br />
                                                 </td>